Skip to content

added wg-policy-spotlight blog #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

added wg-policy-spotlight blog #534

wants to merge 9 commits into from

Conversation

arujjval
Copy link
Contributor

closes #533

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @arujjval!

It looks like this is your first PR to kubernetes/contributor-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/contributor-site has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2024
@arujjval arujjval mentioned this pull request Sep 27, 2024
Closed
11 tasks
ArvindParekh
ArvindParekh reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@ArvindParekh ArvindParekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving the answers to the questions onto a new line to improve readability?

ArvindParekh
ArvindParekh reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@ArvindParekh ArvindParekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going through this again and found some nits :)

@arujjval
Copy link
Contributor Author

@ArvindParekh updated as per your comments.

@chris-short
Copy link
Contributor

Please update the date. After that, I'll lgtm and approve and we'll get this published.

@sftim
Copy link

sftim commented Jan 10, 2025

/hold

We'd usually mirror this kind of article to the main blog. Are we happy to hold off to allow for that?

OK to unhold if we don't want mirroring.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2025
@chris-short
Copy link
Contributor

Yes, we should mirror (thank you, vacation brain is real).

@kaslin
Copy link
Contributor

kaslin commented Jan 17, 2025

Do we need to do anything in particular for the mirroring? @arujjval we need to get a new publish date for this, right?

@sftim
Copy link

sftim commented Jan 17, 2025

Needs a contributor to open a k/website PR that mirrors this one.
It's OK to put draft: true in front matter on these BTW.

@arujjval
Copy link
Contributor Author

@sftim so I have to make a similar PR at here?

Also, need to discuss the date it needs to get published.

@chris-short
Copy link
Contributor

Correct, @arujjval, that's the right place. We would want to copy it there and set the canonical URL to the contributor-site URL. In that PR for the website repo, state that reviews are taking place in the contributor-site pull request and to request edits on this PR

@kaslin
Copy link
Contributor

kaslin commented Jan 31, 2025

Ping, any updates here @arujjval? Help needed?

@arujjval
Copy link
Contributor Author

arujjval commented Feb 1, 2025

@kaslin been a little busy lately.

Have we decided on which date this should be posted?

@arujjval arujjval mentioned this pull request Feb 1, 2025
Merged
@sftim
Copy link

sftim commented Feb 1, 2025

I suggest aiming for publication in late February, because SIG Docs is struggling with blog team capacity (it's mostly me).

@arujjval
Copy link
Contributor Author

arujjval commented Feb 4, 2025

@sftim sure. Please update me about the day chosen. I will make changes to the publication date.

reylejano
reylejano reviewed Feb 24, 2025
View reviewed changes
@kaslin
Copy link
Contributor

kaslin commented Mar 7, 2025

@arujjval checking in on this. Looks like there are some comments to address.

graz-dev
graz-dev reviewed Mar 13, 2025
View reviewed changes
Copy link

@graz-dev graz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arujjval great piece!
I reviewed the article and left some comments about formatting and improving readibility.

@graz-dev graz-dev mentioned this pull request Mar 21, 2025
Closed
11 tasks
@sftim
Copy link

sftim commented Mar 22, 2025

@graz-dev for reported speech, we don't suggest rewordings unless there are obvious problems or we think the original speaker may have been misquoted.

@fsmunoz fsmunoz moved this to Ready for Review in SIG Contribex Comms Status Mar 28, 2025
@fsmunoz fsmunoz moved this from Preliminary Review to PR Review in SIG Contribex Comms Status Mar 28, 2025
jberkus
jberkus suggested changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@jberkus jberkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor cleanup. Also, please edit per @graz-dev review comments as well.

@jberkus
Copy link
Contributor

jberkus commented Apr 10, 2025

@graz-dev good work on copy-edit review!

@arujjval
Copy link
Contributor Author

Sorry for the delay. I have made changes as per the suggestions above.

lmktfy
lmktfy reviewed May 11, 2025
View reviewed changes
lmktfy
lmktfy reviewed May 16, 2025
View reviewed changes
@kaslin
Copy link
Contributor

kaslin commented May 16, 2025

@arujjval You have a publishing date! Check out the new edits and approve them so this can go out on time.

@arujjval
Copy link
Contributor Author

@kaslin @sftim I have made changes and updated the website PR as per suggestions.

lmktfy
lmktfy reviewed May 18, 2025
View reviewed changes
lmktfy
lmktfy reviewed May 18, 2025
View reviewed changes
Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key thing I hope we get right is to mark this as a draft, because that fits with how the blog team (for the main blog) plan to work.

See https://github.com/kubernetes/contributor-site/pull/534/files#r2094645018

However, I also suggested a few little tweaks that I think are worth making.

@arujjval
Copy link
Contributor Author

@sftim, all your suggested changes have been made.

@lmktfy
Copy link
Contributor

lmktfy commented May 23, 2025

Looks good to merge as draft.

Thanks for the work that went into this. I'll also get it scheduled & published.

/LGTM
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arujjval, bashlion, jberkus, lmktfy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2025
@kaslin
Copy link
Contributor

kaslin commented Jun 6, 2025

Looks like this is good to go whenever we're ready to release the hold. Here's a reminder that this exists in case that's useful. Thank you all for your work on this! @sftim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@reylejano reylejano reylejano left review comments

@graz-dev graz-dev graz-dev left review comments

@ArvindParekh ArvindParekh ArvindParekh left review comments

@lmktfy lmktfy lmktfy left review comments

@jberkus jberkus jberkus approved these changes

@bashlion bashlion bashlion approved these changes

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees

@lmktfy lmktfy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Contribex Comms Status
Status: PR Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spotlight: WG Policy