-
Notifications
You must be signed in to change notification settings - Fork 162
blog post in post quantum crypto in k8s #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: datosh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @datosh! |
Signed-off-by: Fabian Kammel <[email protected]>
6a12508
to
d5013cb
Compare
Signed-off-by: Fabian Kammel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Composition/writing check. No real grammar/punctuation editing needed. However, one suggestion on article flow, and one link needs to be replaced.
The rest of the links all look OK.
Note that I have no expertise in the cryptography details covered by the article.
theoretical for many applications, their potential to break current | ||
cryptographic standards is a serious concern, especially for long-lived | ||
systems. This is where _Post-Quantum Cryptography_ (PQC) comes in. In this | ||
article, I\'ll dive into what PQC means for TLS and, more specifically, for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it actually necessary to escape apostrophes? This doesn't break anything, but I don't recall it being required before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I escaped them, because I thought I saw it in the style guide, but now I fail to find a reference.
As you said "it doesn't break anything", so I would leave it as is, unless you disagree.
Signed-off-by: Fabian Kammel <[email protected]>
Thank you, for taking the time to review this @jberkus |
Signed-off-by: Fabian Kammel <[email protected]>
@kubernetes/sig-security-pr-reviews is this article OK to publish (in terms of cryptography / infosec message)? |
[Cloudflare\'s CIRCL] (Cloudflare Interoperable Reusable Cryptographic Library) | ||
library implements some PQC signature schemes like variants of Dilithium, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better:
[Cloudflare\'s CIRCL] (Cloudflare Interoperable Reusable Cryptographic Library) | |
library implements some PQC signature schemes like variants of Dilithium, and | |
Cloudflare's [CIRCL](https://github.com/cloudflare/circl) | |
(Cloudflare Interoperable Reusable Cryptographic Library) | |
implements some PQC signature schemes, such as variants of Dilithium, and |
(and drop the reference later in the article)
Inline hyperlinks are easier to maintain, especially for localization teams. This article may well end up getting localized into up to 13, and counting, target languages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, is this a change to stylesheet from Docs? Because for years we've been telling people to use end links specifically for maintenance purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jberkus first I knew about the preference for end links. Let's take this to SIG Docs' Slack channel?
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
Signed-off-by: Fabian Kammel <[email protected]>
We should be able to get eyes on this next week. |
Hey 👋
I recently spend some time researching the current state of post quantum cryptography in the cloud native industry.
For some topics I found little to no information especially in the Kubernetes ecosystem, so I thought I share my findings with the community!
Discussion on Slack:
Happy for any comments or suggestions on the post.
/cc @lmktfy