Skip to content

KEP-4958: CSI Sidecars All in one #5153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mowangdk
Copy link

@mowangdk mowangdk commented Feb 7, 2025

  • One-line PR description: To combine the source code of the CSI sidecars in a monorepo.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 7, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 7, 2025
@mowangdk mowangdk force-pushed the feature/add_csi_aio_proposal branch from d6d990f to 6b692e1 Compare April 3, 2025 14:46
Copy link
Member

@mauriciopoppe mauriciopoppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, it's looking better every time we review it, good job!

@mowangdk mowangdk force-pushed the feature/add_csi_aio_proposal branch 2 times, most recently from 04c2962 to a57520b Compare April 27, 2025 12:09
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mowangdk
Once this PR has been reviewed and has the lgtm label, please assign deads2k, jsafrane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mowangdk mowangdk force-pushed the feature/add_csi_aio_proposal branch 2 times, most recently from 500c81f to 36ea97f Compare May 19, 2025 02:47
@mowangdk
Copy link
Author

/retest

@mowangdk mowangdk changed the title [WIP]KEP-4958: CSI Sidecars All in one KEP-4958: CSI Sidecars All in one May 29, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2025
@mowangdk mowangdk force-pushed the feature/add_csi_aio_proposal branch from 46709b6 to 69efda3 Compare June 23, 2025 02:18
@mowangdk mowangdk force-pushed the feature/add_csi_aio_proposal branch from 69efda3 to 3b0596f Compare July 20, 2025 14:24
@mowangdk mowangdk force-pushed the feature/add_csi_aio_proposal branch from 3b0596f to 9f5da57 Compare July 20, 2025 14:41
@mowangdk
Copy link
Author

mowangdk commented Jul 20, 2025

/assign @jsafrane @msau42

Please review this KEP at your convenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants