-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-4958: CSI Sidecars All in one #5153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
mowangdk
commented
Feb 7, 2025
- One-line PR description: To combine the source code of the CSI sidecars in a monorepo.
- Issue link: CSI Sidecars All in one #4958
- Other comments:
d6d990f
to
6b692e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, it's looking better every time we review it, good job!
04c2962
to
a57520b
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mowangdk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
500c81f
to
36ea97f
Compare
/retest |
46709b6
to
69efda3
Compare
69efda3
to
3b0596f
Compare
3b0596f
to
9f5da57
Compare