-
Notifications
You must be signed in to change notification settings - Fork 41k
[PodLevelResources] Add validation for Windows OS #133046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @toVersus. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @tallclair @ndixita |
@@ -241,3 +243,23 @@ func isHTTPResponseError(err error) bool { | |||
} | |||
return strings.Contains(urlErr.Err.Error(), "server gave HTTP response to HTTPS client") | |||
} | |||
|
|||
// NewPodLevelResourcesHandler returns a PodAdmitHandler which is used to evaluate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the comment at #132627 (comment), this PR adds a new admission handler to the kubelet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that validatePodResources
currently doesn't have a dedicated unit test. Given that it's complex enough, would you be willing to add one?
14f7dab
to
d81b37b
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: toVersus The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the suggestion! I've added a new unit test specifically for |
Reject Pod with PodLevelResources in spec if Pod targets Windows OS.
Reject pods with PodLevelResources running on Windows nodes at kubelet admission phase
d81b37b
to
02399ed
Compare
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR is taking over from #132627.
Adds the following checks based on the KEP description:
Which issue(s) this PR is related to:
Fixes: #132582
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: