Skip to content
This repository was archived by the owner on Sep 22, 2023. It is now read-only.

Feature/filebrowser in storage proxy #203

Closed
wants to merge 18 commits into from

Conversation

leksikov
Copy link
Contributor

A CLI implementation for starting File Browser in storage proxy. After File Browser starts the CLI opens the web browser tab with url of FileBrowser UI interface.

@leksikov leksikov added this to the 21.03 milestone Jan 21, 2022
@leksikov leksikov self-assigned this Jan 21, 2022
@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #203 (af791a9) into main (2ddf18b) will increase coverage by 0.61%.
The diff coverage is 68.00%.

❗ Current head af791a9 differs from pull request most recent head cce8f76. Consider uploading reports for the commit cce8f76 to get more accurate results

@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   45.36%   45.98%   +0.61%     
==========================================
  Files          73       76       +3     
  Lines        7016     7213     +197     
==========================================
+ Hits         3183     3317     +134     
- Misses       3833     3896      +63     
Impacted Files Coverage Δ
src/ai/backend/client/func/vfolder.py 68.06% <50.00%> (+3.49%) ⬆️
src/ai/backend/client/cli/filebrowser.py 51.85% <51.85%> (ø)
src/ai/backend/client/func/filebrowser.py 68.75% <68.75%> (ø)
src/ai/backend/client/cli/__init__.py 100.00% <100.00%> (ø)
src/ai/backend/client/cli/admin/__init__.py 100.00% <100.00%> (ø)
src/ai/backend/client/cli/admin/filebrowser.py 100.00% <100.00%> (ø)
src/ai/backend/client/session.py 82.39% <100.00%> (+0.11%) ⬆️
src/ai/backend/client/cli/admin/vfolder.py 41.97% <0.00%> (+2.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ddf18b...cce8f76. Read the comment docs.

@leksikov leksikov requested a review from achimnol January 25, 2022 08:10
@leksikov
Copy link
Contributor Author

leksikov commented Jan 25, 2022

Implemented CLI interface to create browser session.

python -m ai.backend.client.cli filebrowser create -v mydata1 -v mydata2

Attach multiple users vfolder to a session.
After successfully starting it prints the url, port number and container id.
Using container id user can destroy the browser session.
python -m ai.backend.client.cli filebrowser destroy [container_id]
Also, WebUI opens in users default web browser tab.

While implementing the filebrowser, I decoupled filebrowser from Vfolder as a separate app.
This will allow having filebrowser its own routing management for more complex commands.
Decoupling will help to improve maintenance and advanced feature implementation of Filebrowser without affecting Vfolder.

Currently there are mypy and pytest difficult issues which were not shown when executing those commands locally.

@achimnol
Copy link
Member

Replaced with lablup/backend.ai#710

@achimnol achimnol closed this Oct 26, 2022
@achimnol achimnol deleted the feature/filebrowser-in-storage-proxy branch October 26, 2022 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants