feat(BA-1213): Add detection and event notifications for kernel/container mismatches #4252
Conversation
github-actions
bot
added
size:L
fregataa
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for private_port, host_ports in src["NetworkSettings"]["Ports"].items(): | ||
| private_port = int(private_port.split("/")[0]) | ||
| if host_ports is None: | ||
| host_ip = "127.0.0.1" |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
| async def handle_dangling_kernel( | ||
| context: AgentRegistry, source: AgentId, event: DanglingKernelDetected | ||
| ) -> None: | ||
| # TODO: Impl dangling kernel handler |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| async def handle_dangling_container( | ||
| context: AgentRegistry, source: AgentId, event: DanglingContainerDetected | ||
| ) -> None: | ||
| # TODO: Impl dangling container handler |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
src/ai/backend/agent/kernel.py
Outdated
| @abstractmethod | ||
| def _init_probe_runner_obj(self) -> ProbeRunner: | ||
| raise NotImplementedError |
There was a problem hiding this comment.
I think private abstractmethod is harmful.
| pass | ||
|
|
||
|
|
||
| class ProbeRunner(Generic[TResourceCtx]): |
There was a problem hiding this comment.
Remove Probe prefix. but Runner is so generic name. please rename proper name.
| version: int | ||
| agent_config: Mapping[str, Any] | ||
| resource_spec: KernelResourceSpec | ||
| service_ports: Any # TODO: type-annotation |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| data: dict[str, Any] | ||
| environ: Mapping[str, Any] | ||
| event_producer: EventProducer | ||
| session_type: SessionTypes = SessionTypes.INTERACTIVE # TODO: Remove default value |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
resolves #4242 (BA-1213)
Checklist: (if applicable)