(dsl): Support Geo bounding box query #651
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmarjanovic
requested changes
Jun 19, 2025
| * @return | ||
| * an instance of [[zio.elasticsearch.query.GeoBoundingBoxQuery]] enriched with the `boost` parameter. | ||
| */ | ||
| def boost(value: Double): GeoBoundingBoxQuery[S] |
There was a problem hiding this comment.
Why don't we extend HasBoost?
| * @return | ||
| * an instance of [[zio.elasticsearch.query.GeoBoundingBoxQuery]] enriched with the `ignoreUnmapped` parameter. | ||
| */ | ||
| def ignoreUnmapped(value: Boolean = false): GeoBoundingBoxQuery[S] |
There was a problem hiding this comment.
Let's use ignoreUnmapped without params.
There was a problem hiding this comment.
Also, why shouldn't we use already existing HasIgnoreUnmapped?
dbulaja98
requested changes
Jun 20, 2025
| * @return | ||
| * an instance of [[zio.elasticsearch.query.GeoBoundingBoxQuery]] enriched with the `ignoreUnmapped` parameter. | ||
| */ | ||
| def ignoreUnmapped(value: Boolean = false): GeoBoundingBoxQuery[S] |
There was a problem hiding this comment.
Also, why shouldn't we use already existing HasIgnoreUnmapped?
| * @return | ||
| * an instance of [[zio.elasticsearch.query.GeoBoundingBoxQuery]] enriched with the `queryName` parameter. | ||
| */ | ||
| def name(value: String): GeoBoundingBoxQuery[S] |
There was a problem hiding this comment.
Since we have this in GeoDistanceQuery, you should extract this as HasQueryName and use this option in both queries.
| * @return | ||
| * an instance of [[zio.elasticsearch.query.GeoDistanceQuery]] enriched with the `validationMethod` parameter. | ||
| */ | ||
| def validationMethod(value: ValidationMethod): GeoBoundingBoxQuery[S] |
Comment on lines
+556
to
+557
| topLeft: GeoPoint, | ||
| bottomRight: GeoPoint, |
| def validationMethod(value: ValidationMethod): GeoBoundingBoxQuery[S] = | ||
| self.copy(validationMethod = Some(value)) | ||
|
|
||
| private[elasticsearch] override def toJson(fieldPath: Option[String]): Json = |
|
|
||
| To ignore unmapped fields (fields that do not exist in the mapping), use the ignoreUnmapped method: | ||
| ```scala | ||
|
|
| .boost(1.5) | ||
| ``` | ||
|
|
||
| To ignore unmapped fields (fields that do not exist in the mapping), use the ignoreUnmapped method: |
There was a problem hiding this comment.
Suggested change
| To ignore unmapped fields (fields that do not exist in the mapping), use the ignoreUnmapped method: | |
| To ignore unmapped fields (fields that do not exist in the mapping), use the `ignoreUnmapped` method: |
| ```scala | ||
|
|
||
| val queryWithIgnoreUnmapped = | ||
| geoBoundingBoxQuery("location", GeoPoint(40.73, -74.1), GeoPoint(40.01, -71.12)) |
| To give the query a name for identification in the response, use the name method: | ||
| ```scala | ||
| val queryWithName = | ||
| geoBoundingBoxQuery("location", GeoPoint(40.73, -74.1), GeoPoint(40.01, -71.12)) |
| import zio.elasticsearch.query.ValidationMethod | ||
|
|
||
| val queryWithValidationMethod = | ||
| geoBoundingBoxQuery("location", GeoPoint(40.73, -74.1), GeoPoint(40.01, -71.12)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #91