core: Fix some missing generic types #31658
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
CodSpeed WallTime Performance ReportMerging #31658 will not alter performanceComparing
|
CodSpeed Instrumentation Performance ReportMerging #31658 will not alter performanceComparing Summary
|
cbornet
force-pushed
the
fix-missing-generic-types
branch
from
b16dda7 to
d96c3e6
Compare
cbornet
commented
Jun 19, 2025
| messages = convert_to_messages(messages) | ||
| messages_: Iterable[MessageLikeRepresentation] = ( | ||
| [messages] | ||
| if (is_single := isinstance(messages, (BaseMessage, dict, str, tuple))) |
There was a problem hiding this comment.
Is it correct to add tuple to the type check ? It seems to be missing.
cbornet
force-pushed
the
fix-missing-generic-types
branch
2 times, most recently
from
e6f2672 to
e304d63
Compare
cbornet
force-pushed
the
fix-missing-generic-types
branch
from
e304d63 to
966b653
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://mypy.readthedocs.io/en/stable/config_file.html#confval-disallow_any_generics