Skip to content

fix(tests): add missing __init__.py to retrievers unit test directory #32421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

harshamoole
Copy link

Description:
This PR adds a missing __init__.py file to the retrievers unit test directory to ensure it is recognized as a proper Python package. This helps in test discovery and improves modular structure.

Issue:
Closes [insert issue number here if any, or write "Not linked to a specific issue."]

Dependencies:
None

Twitter handle:
N/A

Copy link

vercel bot commented Aug 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchain Ignored Ignored Preview Aug 19, 2025 10:03am

Copy link

codspeed-hq bot commented Aug 5, 2025

CodSpeed WallTime Performance Report

Merging #32421 will not alter performance

Comparing harshamoole:fix/add-init-retrievers-test (702c0c4) with master (d204f0d)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Copy link

codspeed-hq bot commented Aug 5, 2025

CodSpeed Instrumentation Performance Report

Merging #32421 will not alter performance

Comparing harshamoole:fix/add-init-retrievers-test (702c0c4) with master (d204f0d)

Summary

✅ 14 untouched benchmarks

@harshamoole
Copy link
Author

Hi team! This PR adds a missing init.py file in the retrievers unit test directory to ensure the tests are discoverable and follow standard structure.
All checks are passing. Ready for review.

@mdrxy
Copy link
Collaborator

mdrxy commented Aug 5, 2025

All checks are passing. Ready for review.

@harshamoole they are not

Copy link
Collaborator

@mdrxy mdrxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be an empty file

@mdrxy mdrxy added the langchain Related to the package `langchain` label Aug 6, 2025
@harshamoole
Copy link
Author

Hi team,
This PR adds a missing __init__.py file in the retrievers unit test directory to ensure test discovery and maintain standard structure.

Verifications:

  • black . → Passed
  • flake8 . → Passed (only warnings outside scope)
  • pytest → Ran successfully, encountered unrelated errors in other modules, but this addition is isolated and should not affect them.

This is a minimal, scoped fix. No additional dependencies or logic introduced.

Ready for review when convenient.

@mdrxy
Copy link
Collaborator

mdrxy commented Aug 6, 2025

Screenshot @harshamoole

@mdrxy
Copy link
Collaborator

mdrxy commented Aug 19, 2025

CI still failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
langchain Related to the package `langchain`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants