Skip to content

docs(core): add message-type-specific documentation for message name fields #32469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: wip-v0.4
Choose a base branch
from

Conversation

mdrxy
Copy link
Collaborator

@mdrxy mdrxy commented Aug 8, 2025

Updates the name field documentation in v1 messages to provide message-type-specific guidance instead of generic descriptions. The current documentation incorrectly presents the field as purely "human-readable" when it serves critical functional purposes that vary by message type.

  • ToolMessage.name is effectively required by most providers despite being typed as Optional[str]
  • AIMessage.name is critical for multi-agent systems but optional for single-agent scenarios

Examples

langchain-openai

langgraph-supervisor-py

langchain-google

langchain-community

@mdrxy mdrxy requested a review from eyurtsev as a code owner August 8, 2025 17:20
Copy link

vercel bot commented Aug 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2025 5:27pm

Copy link

codspeed-hq bot commented Aug 8, 2025

CodSpeed WallTime Performance Report

Merging #32469 will not alter performance

Comparing mdrxy/messages-name-docs (56379fb) with wip-v0.4 (2f0c642)1

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Footnotes

  1. No successful run was found on wip-v0.4 (7f989d3) during the generation of this report, so 132ed67 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link

codspeed-hq bot commented Aug 8, 2025

CodSpeed Instrumentation Performance Report

Merging #32469 will not alter performance

Comparing mdrxy/messages-name-docs (56379fb) with wip-v0.4 (2f0c642)1

Summary

✅ 14 untouched benchmarks

Footnotes

  1. No successful run was found on wip-v0.4 (7f989d3) during the generation of this report, so 132ed67 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@mdrxy mdrxy added the core Related to the package `langchain-core` label Aug 8, 2025
@mdrxy mdrxy requested a review from ccurme August 8, 2025 20:54
@mdrxy mdrxy added this to the v1 milestone Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to the package `langchain-core`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant