refactor(core): improve beta decorator #32505
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
CodSpeed WallTime Performance ReportMerging #32505 will not alter performanceComparing
|
| def beta_property(self, value: str) -> None: | ||
| return | ||
|
|
||
| @beta() |
There was a problem hiding this comment.
Tips: when using setter and/or deleter, need to put the beta decorator on the last method.
CodSpeed Instrumentation Performance ReportMerging #32505 will not alter performanceComparing Summary
|
cbornet
force-pushed
the
beta-property
branch
2 times, most recently
from
8400260 to
404070a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the beta decorator's property handling by replacing a custom _BetaProperty subclass with a standard property object created using wrapper functions. This change improves docstring accessibility, allowing ClassWithBetaMethods.beta_property.__doc__ to work correctly.
Key Changes:
- Simplified property decoration by removing the custom
_BetaPropertysubclass - Created wrapper functions (
_fget,_fset,_fdel) that emit warnings and delegate to the original property methods - Updated tests to verify multiple property operations (get, set, delete) all trigger beta warnings
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
libs/core/langchain_core/_api/beta_decorator.py |
Replaced custom _BetaProperty subclass with standard property using wrapper functions |
libs/core/tests/unit_tests/_api/test_beta_decorator.py |
Added property setter/deleter to test class and updated tests to verify all property operations emit warnings |
| @beta() # type: ignore[misc] | ||
| @beta_property.deleter | ||
| def beta_property(self) -> None: | ||
| return |
There was a problem hiding this comment.
[nitpick] Explicit return statements are unnecessary in functions that return None. This can be removed for cleaner code.
| return | |
| pass |
Copilot uses AI. Check for mistakes.
This is better than using a subclass as returning a
propertyworks withClassWithBetaMethods.beta_property.__doc__