Skip to content

feat: Okta support for SCIM #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 21, 2025
Merged

feat: Okta support for SCIM #949

merged 6 commits into from
Aug 21, 2025

Conversation

bvs-langchain
Copy link
Contributor

  • enhances existing SCIM documentation for Okta
  • adds sections to SAML and OAuth2.0 docs for Okta

@vercel Vercel
Copy link

vercel bot commented Aug 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
langsmith-docs Ready Ready Preview Comment Aug 21, 2025 4:44pm

@katmayb katmayb self-requested a review August 20, 2025 17:12
katmayb
katmayb approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@katmayb katmayb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvs-langchain Small nits and a suggestion on the step structure. Once you've merged, I'll port this over to the mintlify site.

docs/administration/how_to_guides/organization_management/set_up_scim.mdx Outdated

## Set up SCIM for your organization
:::note
If you use one of the identity providers [below](#identity-provider-idp-setup), follow the instructions there
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the identity provider setup a prerequisite for Step 1? I wasn't exactly sure what this note meant?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm finding the ordering a little confusing only based on the two scenarios. It may help to change "here" and "there" for links to steps to make it very clear what they mean.
I'm wondering if we need to lay out the steps exactly based on whatever scenario a user has to complete. It could be something you explain with a list between the Configuration steps header and the Step 1 header. So,

There are two scenarios for SAML SSO configuration:

  • your explanation. Follow these steps for setup:
    • Identity provider setup (Configure API Integration [link] onward)
    • Then, complete ....
  • your explanation. Follow these steps:
    • The Setup SAML SSO guide.
    • The steps [link to steps]

I may have misunderstood, so feel free to take this as just a suggestion or not a useful comment 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this, lmk how it looks. happy to chat through as well

katmayb
katmayb approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@katmayb katmayb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @bvs-langchain !

@bvs-langchain bvs-langchain removed the request for review from langchain-infra August 21, 2025 21:19
@bvs-langchain bvs-langchain merged commit 77af217 into main Aug 21, 2025
12 of 13 checks passed
@bvs-langchain bvs-langchain deleted the brian/inf-691-okta-idp-support branch August 21, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katmayb katmayb katmayb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bvs-langchain @katmayb