feat: Make webpage summarization timeout configurable #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a configurable timeout for the webpage summarization process. Previously, the `summarize_webpage` function in `utils.py` had a hardcoded 60-second timeout. This change allows users to specify a custom timeout via the `summarization_timeout` field in the `Configuration` class, providing more flexibility for varying content lengths and network conditions. - Added `summarization_timeout` field to `Configuration` in `configuration.py`. - Modified `summarize_webpage` in `utils.py` to accept and use the new timeout. - Updated `tavily_search` to pass the configurable timeout to `summarize_webpage`.
rlancemartin
force-pushed
the
main
branch
2 times, most recently
from
214871e to
c84ad97
Compare
|
@SyedaAnshrahGillani thank you! please resolve conflicts and see recent updates. there is a 60s timeout now. |
|
@rlancemartin Thanks for the heads-up! I've now merged the latest changes from the main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a configurable timeout for the webpage summarization process. Previously, the
summarize_webpagefunction inutils.pyhad a hardcoded 60-second timeout. This change allows users to specify a custom timeout via thesummarization_timeoutfield in theConfigurationclass, providing more flexibility for varying content lengths and network conditions.summarization_timeoutfield toConfigurationinconfiguration.py.summarize_webpageinutils.pyto accept and use the new timeout.tavily_searchto pass the configurable timeout tosummarize_webpage.