Fix bug json parsing #1553
Open
Fix bug json parsing #1553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
learningbizz
commented
Aug 8, 2025
| return ( | ||
| <CodeBlock | ||
| language={strResult?.length > MAX_LENGTH_JSON_PREVIEW ? '' : 'json'} | ||
| bgColor={toolResponse.isError ? 'bg-destructive-muted' : undefined} | ||
| > | ||
| {JSON.stringify(result, null, 2)} | ||
| {strResult} |
There was a problem hiding this comment.
Still parses well the tool response
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this as a PR to confirm my understanding of this situation:
The getResult() method returns a parsed JSON object if its a JSON string, or already an object, or double encoded JSON string, passing the isString to false, and a string if its just a simple string.
If this is the case, then the result from this getResult should be the one used to calculate the length of the JSON, not the previous object passed from the backend. Also, there is no need to stringify again if its done above
Do u also agree?