Skip to content

Conversation

iamjpotts
Copy link
Contributor

Does your PR solve an issue?

Resolves this cargo check warning:

    warning: ./sqlx-cli/Cargo.toml: `default-features` is ignored for sqlx, since `default-features` was not specified for 
    `workspace.dependencies.sqlx`, this could become a hard error in the future

Is this a breaking change?

No:

  • Would only affect dependencies of sqlx-cli which is already attempting to set default-features=false but that has no effect (thus the warning) because the workspace level declaration of the dependency brings in all default features.
  • sqlx-cli is a binary crate, not a library crate

@abonander
Copy link
Collaborator

I tried this but it breaks the examples. I don't want them to use default-features = false.

@iamjpotts iamjpotts force-pushed the jp/cargo-workspace-warning branch from a890d1b to e96f176 Compare August 22, 2025 04:10
@iamjpotts
Copy link
Contributor Author

I tried this but it breaks the examples. I don't want them to use default-features = false.

It did break one of them, but I fixed it by adding macros to its required features for the sqlx dependency.

@iamjpotts
Copy link
Contributor Author

The examples passed ci after the minor tweak to one of them.

this could become a hard error in the future seems like reasonable motivation for the change.

@iamjpotts iamjpotts marked this pull request as ready for review August 22, 2025 04:24
@abonander abonander merged commit 5d4e1a4 into launchbadge:main Aug 27, 2025
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants