Skip to content

remove vars file usage; rename FE variables #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

Conversation

iignatevich
Copy link
Contributor

No description provided.

@davidferlay
Copy link
Contributor

davidferlay commented Jun 30, 2025

Overall all good ! Although I faced an issue when launching web ui with no variables key in config file:

➜  ski-platform git:(master) plasmactlx web --ui-assets=/home/dferlay/Sources/launchr/web/client/dist --foreground --keyring-passphrase-file /tmp/kp
                             
 INFO  You can reach the web server at this URL: http://localhost:8080
2025/06/30 11:30:58 http: panic serving [::1]:46118: assignment to entry in nil map
goroutine 27 [running]:
net/http.(*conn).serve.func1()
	net/http/server.go:1947 +0xbe
panic({0x22213c0?, 0x41a3b70?})
	runtime/panic.go:792 +0x132
github.com/launchrctl/web/server.(*launchrServer).GetCustomisationConfig(0x10?, {0x2d02380, 0xc000232700}, 0xc00056f900?)
	github.com/launchrctl/[email protected]/server/api.go:58 +0xac
github.com/launchrctl/web/server.(*ServerInterfaceWrapper).GetCustomisationConfig.func1({0x2d02380?, 0xc000232700?}, 0x1?)
	github.com/launchrctl/[email protected]/server/openapi.gen.go:505 +0x35
net/http.HandlerFunc.ServeHTTP(0x1?, {0x2d02380?, 0xc000232700?}, 0x1?)
	net/http/server.go:2294 +0x29
github.com/launchrctl/web/server.(*ServerInterfaceWrapper).GetCustomisationConfig(0xc0005564b0, {0x2d02380, 0xc000232700}, 0xc00027a640)
	github.com/launchrctl/[email protected]/server/openapi.gen.go:512 +0xc5
net/http.HandlerFunc.ServeHTTP(0xc0003245a0?, {0x2d02380?, 0xc000232700?}, 0x0?)
	net/http/server.go:2294 +0x29
github.com/go-chi/chi/v5.(*ChainHandler).ServeHTTP(0xc0006422d0?, {0x2d02380?, 0xc000232700?}, 0xc00035e184?)
	github.com/go-chi/chi/[email protected]/chain.go:31 +0x26
github.com/go-chi/chi/v5.(*Mux).routeHTTP(0xc00004e300, {0x2d02380, 0xc000232700}, 0xc00027a640)
	github.com/go-chi/chi/[email protected]/mux.go:480 +0x2e2
net/http.HandlerFunc.ServeHTTP(0xc000021ea0?, {0x2d02380?, 0xc000232700?}, 0xc00027a640?)
	net/http/server.go:2294 +0x29
github.com/go-chi/cors.(*Cors).Handler-fm.(*Cors).Handler.func1({0x2d02380, 0xc000232700}, 0xc00027a640)
	github.com/go-chi/[email protected]/cors.go:228 +0x17e
net/http.HandlerFunc.ServeHTTP(0x2d17e08?, {0x2d02380?, 0xc000232700?}, 0x41a57a0?)
	net/http/server.go:2294 +0x29
github.com/go-chi/chi/v5.(*Mux).ServeHTTP(0xc00004e300, {0x2d02380, 0xc000232700}, 0xc00027a500)
	github.com/go-chi/chi/[email protected]/mux.go:90 +0x2ee
net/http.serverHandler.ServeHTTP({0xc00065a8a0?}, {0x2d02380?, 0xc000232700?}, 0x6?)
	net/http/server.go:3301 +0x8e
net/http.(*conn).serve(0xc00061e480, {0x2d17dd0, 0xc0005567e0})
	net/http/server.go:2102 +0x625
created by net/http.(*Server).Serve in goroutine 1
	net/http/server.go:3454 +0x485

User would expect webui to launch successfully and use default values in that case

Using config with:

web:
  variables: []

works successfully though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor customization config to use key:value Update variables default values Rename ui variables
2 participants