Feat/cookie consent package #173
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katarzynagrasewicz
requested review from
konowrockis,
Komoszek,
kamilgacan,
BeerHobbyist,
alszczep and
kumalg
as code owners
konowrockis
reviewed
Aug 18, 2025
konowrockis
reviewed
Aug 18, 2025
Komoszek
reviewed
Aug 20, 2025
Komoszek
reviewed
Aug 22, 2025
| function setDefaultConsent(serviceKeys: ServiceKey[]) { | ||
| gtag({ | ||
| event: "default_cookie_consent", | ||
| settings: Object.fromEntries(serviceKeys.map(serviceName => [serviceName as ServiceKey, "denied"])), |
There was a problem hiding this comment.
Hmm, does this as ServiceKey even does anything? Object.fromEntries always returns {[key: string]: T}, regardless of key's type
| } | ||
| } | ||
|
|
||
| const languageTranslations: Record<string, any> = {} |
There was a problem hiding this comment.
Suggested change
| const languageTranslations: Record<string, any> = {} | |
| const languageTranslations: Record<string, Translation> = {} |
| langConfig: (typeof config)[Language], | ||
| options: { analytics?: boolean; advertisement?: boolean; functionality?: boolean; security?: boolean }, | ||
| ) { | ||
| const sections: any[] = [ |
There was a problem hiding this comment.
Suggested change
| const sections: any[] = [ | |
| const sections = [ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.