Skip to content

Tests for distinctOn() and selectDistinct() guard #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Tests for distinctOn() and selectDistinct() guard #301

wants to merge 2 commits into from

Conversation

danon
Copy link
Member

@danon danon commented Apr 25, 2023 •
edited
Loading

shouldFailForDistinctOnAndSelectDistinct() fails, probably a missing guard in selectDistinct().

Or perhaps a common guard in Dialect would be better?

@danon danon requested a review from bbankowski April 25, 2023 11:50
danon referenced this pull request Apr 25, 2023
@bbankowski
[ORM] Added support for DISTINCT ON in PostgreSQL dialect.
271826d
@letsdrink letsdrink deleted a comment from coveralls Apr 25, 2023
@letsdrink letsdrink deleted a comment from coveralls Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbankowski bbankowski Awaiting requested review from bbankowski

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@danon