You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds error handling and retry mechanism for DML execution failures in the validateSchemaNode. Previously, DML execution errors would fail immediately without any retry logic, even for transient errors like constraint violations that might succeed on retry.
What would you like reviewers to focus on?
The retry logic implementation for DML execution errors
The list of retryable error patterns (constraint violations, foreign keys, etc.)
Test coverage for all error scenarios
Testing Verification
Unit tests have been added to verify:
Retryable error detection works correctly
Retry mechanism respects the max retry limit
Non-retryable errors fail immediately
Mixed success/failure scenarios are handled properly
What was done
Add error handling and retry mechanism for DML execution in validateSchemaNode
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoritakaIkeda
changed the base branch from
main
to
feat/pr9-add-combined-execution
Issue
Why is this change needed?
This PR adds error handling and retry mechanism for DML execution failures in the validateSchemaNode. Previously, DML execution errors would fail immediately without any retry logic, even for transient errors like constraint violations that might succeed on retry.
What would you like reviewers to focus on?
Testing Verification
Unit tests have been added to verify:
What was done
pr_agent:summary
Detailed Changes
validateSchemaNode.tsto check for retryable errors and implement retry logicRETRYABLE_ERROR_PATTERNSconstant to identify errors that should trigger retriespr_agent:walkthrough
Additional Notes
This PR builds on the combined DDL/DML execution feature and adds robust error handling specifically for DML execution failures.
🤖 Generated with Claude Code