You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codebase had accumulated unused variables, imports, and functions that were not being detected by our existing tooling. While we use knip for detecting unused exports, it doesn't catch unused variables and imports within files. This change addresses that gap by:
Configuring ESLint to detect unused variables and imports across the codebase
Cleaning up existing unused code that knip couldn't detect
Adding pattern matching for type inference schemas (valibot/zod patterns)
Improving overall code quality and reducing bundle size
Changes
ESLint Configuration
Added @typescript-eslint/no-unused-vars rule to base ESLint configuration
Configured ignore patterns for underscore-prefixed variables
Added Schema$ pattern to support valibot/zod type inference variables
- Add @typescript-eslint/no-unused-vars rule to base ESLint config
- Allow variables ending with 'Schema' for type inference patterns
- Configure ignore patterns for underscore-prefixed variables
- Support valibot and other type inference libraries
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
- Remove unused variable 'agentType' in Chat.tsx
- Remove unused imports: TimelineItemEntry, v, TablesInsert, ErrorInfo
- Clean up timelineUtils.ts by removing unused functions and constants
- Add eslint-disable comment for counter variables in schema-bench
- All changes based on ESLint no-unused-vars rule detection
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.
FunamaYukina
changed the title
Configure ESLint no-unused-vars rule and clean up unused code
Configure ESLint no-unused-vars rule and clean up unused code
Jul 18, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FunamaYukina
changed the title
Why is this change needed?
The codebase had accumulated unused variables, imports, and functions that were not being detected by our existing tooling. While we use knip for detecting unused exports, it doesn't catch unused variables and imports within files. This change addresses that gap by:
Changes
ESLint Configuration
@typescript-eslint/no-unused-varsrule to base ESLint configurationSchema$pattern to support valibot/zod type inference variablesCode Cleanup
agentTypein Chat.tsxTimelineItemEntry,v,TablesInsert,ErrorInfotimelineUtils.tsby removing 400+ lines of unused functions and constantsBenefits
Test plan
🤖 Generated with Claude Code