Fixed bug #13493: Assertion failure at SDL_AddTouch with Android API 28 #13716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slouken
reviewed
Aug 8, 2025
src/video/android/SDL_androidtouch.h
Outdated
| @@ -25,3 +25,4 @@ | |||
| extern void Android_InitTouch(void); | |||
| extern void Android_QuitTouch(void); | |||
| extern void Android_OnTouch(SDL_Window *window, int touch_device_id_in, int pointer_finger_id_in, int action, float x, float y, float p); | |||
| extern SDL_TouchID Android_ConvertTouchdId_Java_to_SDL(int touch_device_id_in); | |||
There was a problem hiding this comment.
Naming suggestion:
Suggested change
| extern SDL_TouchID Android_ConvertTouchdId_Java_to_SDL(int touch_device_id_in); | |
| extern SDL_TouchID Android_ConvertJavaTouchID(int touchID); |
…droid API 28 Java touch id should be -1 because it's reserved for internal SDL synthetic events. It should also not be 0, because this is SDL invalid value.
1bsyl
force-pushed
the
br_fix_android_touch_id
branch
from
2edb264 to
e23a072
Compare
|
@slouken patch updated thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java touch id should be -1 because it's reserved for internal SDL synthetic events.
It should also not be 0, because this is SDL invalid value.