cpuinfo: Added SDL_GetSystemPageSize. #14209
Merged
+85
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezero
reviewed
Oct 10, 2025
|
|
|
I avoided getpagesize because it's deprecated in POSIX (almost everything modern uses sysctl/HW_PAGESIZE), but I guess we could plug this into CMake in case Solaris or something uses it still. |
icculus
force-pushed
the
sdl3-getsystempagesize
branch
from
56fd8d8 to
8004931
Compare
|
It turns out our CMake code was already checking for getpagesize(), so I added it. I moved the hardcoded page sizes (Nintendo 3DS, PS2, etc) to be the first checks, so the compiler can optimize out any POSIX stuff those SDKs might offer, and added a check for a SDL_PLATFORM_SYSTEM_PAGE_SIZE_PRIVATE define that the console forks can implement without touching this code. This is ready to merge whenever we're happy with it, at this point, I think. |
sezero
reviewed
Oct 11, 2025
icculus
force-pushed
the
sdl3-getsystempagesize
branch
from
8004931 to
12c34bb
Compare
slouken
reviewed
Oct 11, 2025
icculus
force-pushed
the
sdl3-getsystempagesize
branch
from
12c34bb to
6b12bfd
Compare
slouken
approved these changes
Oct 11, 2025
madebr
reviewed
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14201.