ci(vss): auto-extract Gradle version number ffg upgrade #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've assigned @tnull as a reviewer! |
tnull
reviewed
Jul 8, 2025
| @@ -61,10 +61,15 @@ jobs: | |||
| run: | | |||
| # Print Info | |||
| java -version | |||
| gradle --version | |||
| GRADLE_VERSION=$(gradle --version | grep "Gradle" | awk '{print $2}') | |||
There was a problem hiding this comment.
Shouldn't we just fail here? If we can't extract the version it probably means something during the install went wrong or something unexpected happened, no? I think we should then just abort here rather than continuing with a default, which might just be confusing to debug if it ever gets hit?
| echo "Failed to extract Gradle version, using default" | ||
| GRADLE_VERSION="9.0.0-rc-1" | ||
| fi | ||
| echo $GRADLE_VERSION |
There was a problem hiding this comment.
Maybe still print the entire gradle --version in addition to the extracted value?
| @@ -61,12 +61,12 @@ jobs: | |||
| run: | | |||
| # Print Info | |||
| java -version | |||
| GRADLE_VERSION=$(gradle --version | grep "Gradle" | awk '{print $2}') | |||
| GRADLE_VERSION=$(gradle --version | awk '/^Gradle/ {print $2}' | head -1) | |||
There was a problem hiding this comment.
Seems some of these changes should go in the first commit?
enigbe
force-pushed
the
2025-07-fix-vss-integration-ci
branch
from
0cef221 to
ef9254a
Compare
enigbe
force-pushed
the
2025-07-fix-vss-integration-ci
branch
from
ef9254a to
0392313
Compare
update to Gradle 9.0 and auto-extract version number.
enigbe
force-pushed
the
2025-07-fix-vss-integration-ci
branch
from
0392313 to
8c157c3
Compare
|
Squashed! |
tnull
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Related Issues