Noop HTLC itest fixes #1080
Open
Noop HTLC itest fixes #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The backwards compatibility itest is expected to fail, as the sender of the HTLCs expects a different commitment view than what the receiver is constructing. Currently the tapd feature is hidden behind the |
GeorgeTsagk
force-pushed
the
noop-add-itest
branch
from
25098da to
e4a0bdb
Compare
GeorgeTsagk
force-pushed
the
noop-add-itest
branch
from
e4a0bdb to
6793913
Compare
|
Bumped lnd & tapd to the commits that address all latest feedback |
guggero
reviewed
Jul 7, 2025
There was a problem hiding this comment.
Looks like the backward compatibility itest causes a force close, due to the NoOp HTLC option.
We probably need to set that to false at the start of a backward compat test (and restore it to true with a defer or t.Cleanup()).
Other than that looks good to me.
|
@Roasbeef: review reminder |
GeorgeTsagk
force-pushed
the
noop-add-itest
branch
from
6793913 to
399a498
Compare
Many of our itest cases would rely on making multiple asset keysends to initialize the state for our test case. This would include the expectation that the receiver would receive enough sats to be able to pay back the sender. With noop HTLCs the sender only sends the sats to the receiver iff they are currently below reserve. We add some direct sats keysends to give the receiver some sats balance to be able to support sending back asset HTLCs.
GeorgeTsagk
force-pushed
the
noop-add-itest
branch
from
399a498 to
a854870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies some of our existing custom channels itests to now include some manual sats keysends to provide enough liquidity on some nodes to carry out the test case.
Our previous expectation was that asset HTLCs would always pay some sats to the receiver, but now this only happens up to the chan reserve amount.
Based on: lightningnetwork/lnd#9871 , lightninglabs/taproot-assets#1567
Extra note
Since we introduced NoOp HTLCs on LND/Tapd that means we are no longer compatible with older versions. That leads to some itest failures, specifically the test cases that declared a backwards compatibility version for some of the nodes in the network topology.
Temporarily we want to remove the backwards compatibility versions from the itests, and restore them when we add the peer messaging for feature bit negotiation, which would allow for smooth upgrading on the taproot asset channels.