-
Notifications
You must be signed in to change notification settings - Fork 132
multi: allow supply commit state machine to accept pending updates during state transition #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Roasbeef
wants to merge
18
commits into
main
Choose a base branch
from
updates-mempool
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,213
−189
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
0d90a02
tapdb: allow danging updates, and add a new frozen bool to state tran…
Roasbeef 33e0407
tapdb: add group_key to supply_update_events
Roasbeef dba58f4
tapdb: add new queries to handle dangling updates
Roasbeef 77af31c
tapdb: update supply commit queries to account for the new frozen fie…
Roasbeef 60ac4da
tapdb: update the supply update insertion logic to support dangling u…
Roasbeef 3557ab1
tapdb: add method to freeze a state transition
Roasbeef 5802d8b
tapdb: generate sqlc structs
Roasbeef 809477b
tapdb: add method to bind dangling updates to a new state transitions
Roasbeef f758aa5
tapdb: update tests to factor in new frozen/dangling logic in InsertP…
Roasbeef 5a31596
universe/supplycommit: add new bind+freeze methods to StateMachineStore
Roasbeef c403151
universe/supplycommit: freeze state transition before tree construction
Roasbeef a6be47a
universe/supplycommit: allow new supply updates to be inserted in all…
Roasbeef 199638d
universe/supplycommit: add new state transitions to bind any dangling…
Roasbeef fe5299d
universe/supplycommit: update unit tests due to state machine updates
Roasbeef ede7e1e
tapdb: add TestBindDanglingUpdatesToTransition test
Roasbeef 0d6476b
universe/supplycommit: add new sub-test for self-transition with dang…
Roasbeef 4dc3a8a
universe/supplycommit: update README.md to detail dangling updates
Roasbeef ef03639
universe/supplycommit: add unit tests for dangling update transitions
Roasbeef File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: IMO it's a bit easier to see that nothing is missing when all the changes to the SQL schema and queries (and updating the generated code) are in a single commit.