[group key addrs 5/6]: Add Pedersen unique script key type #1621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
force-pushed
the
pedersen-keys-refactor
branch
from
5687720 to
46d9159
Compare
Pull Request Test Coverage Report for Build 16141989592Details
💛 - Coveralls |
guggero
force-pushed
the
pedersen-keys-refactor
branch
from
46d9159 to
e5fdf7e
Compare
|
Going to look into the test failures (I think the mock just needs some mutexes). |
guggero
force-pushed
the
pedersen-keys-refactor
branch
3 times, most recently
from
555c711 to
6a85168
Compare
ffranr
reviewed
Jul 1, 2025
authmailbox/multi_subscription.go
Outdated
Comment on lines
60
to
68
| // Subscribe adds a new subscription for the specified client URL and receiver | ||
| // key. It starts a new mailbox client if one does not already exist for the | ||
| // given URL. The subscription will receive messages that match the provided | ||
| // filter and will send them to the shared message queue. | ||
| func (m *MultiSubscription) Subscribe(serverURL url.URL, | ||
| receiverKey keychain.KeyDescriptor, filter MessageFilter) error { |
There was a problem hiding this comment.
Maybe this should be thread safe? I'm not sure how this might be used. But if it's going to be called from an RPC endpoint then it probably needs to be thread safe.
There was a problem hiding this comment.
Currently we only access this from a single Goroutine in the asset custodian. But doesn't hurt to make it thread safe, so I did that.
proof/send.go
Outdated
Comment on lines
28
to
40
| const ( | ||
| // SendFragmentV0 is the first version of the send fragment. | ||
| SendFragmentV0 SendFragmentVersion = 0 | ||
| ) |
There was a problem hiding this comment.
Might be useful to reserve 0 for "unspecified version". Useful for returning errors on version parsing.
Might also be useful to have a "latest version" var here.
Roasbeef
requested changes
Jul 2, 2025
github-project-automation
bot
moved this from 🏗 In progress
to 👀 In review
in Taproot-Assets Project Board
guggero
force-pushed
the
pedersen-keys-refactor
branch
3 times, most recently
from
d050a45 to
770baa6
Compare
|
I addressed all comments, should be ready for another round of review. |
guggero
force-pushed
the
pedersen-keys-refactor
branch
from
770baa6 to
d029ca6
Compare
Because we'll use the address' script key as the bare/raw public key that will be tweaked for each individual output of an address v2 send, we'll need to be able to find addresses by that script key. We'll also make the script key unique for v2 addresses to avoid multiple records being returned here.
This introduces a workaround that gets us WHERE xxx IN (...) queries working with a little trick. See the comment in scripts/gen_sqlc_docker.sh for more information on how this works and why the workaround is needed.
This MultiSubscription helper struct allows us to subscribe to receive messages for multiple keys held by a receiving wallet but all consolidated into a single message channel.
We need to place these types in the proof package because the proof courier will need access to them. And because we already use the proof package from the address package, we can't place the new types there, as that would create a circular package dependency.
guggero
force-pushed
the
pedersen-keys-refactor
branch
from
d029ca6 to
7436356
Compare
ffranr
approved these changes
Jul 9, 2025
| SendFragmentVersionUnknown SendFragmentVersion = 0 | ||
|
|
||
| // SendFragmentV0 is the first version of the send fragment. | ||
| SendFragmentV0 SendFragmentVersion = 1 |
There was a problem hiding this comment.
might be nice to call this SendFragmentV1 so that the enum value corresponds to the version in code, might be confusing otherwise
There was a problem hiding this comment.
Yeah, makes sense. I'll rename it in the follow-up PR.
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More commits extracted from #1587 that contain the last (mostly) non-functional changes that can be merged independently before we're starting to change the address behavior.