Bugfix supply commit state machine #1655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows deriving a supply commit TxOut without specifying all RootCommitment fields. We make RootCommitTxOut exportable so that we can use it in itests.
Refactor newRootCommitment to ensure the commit transaction is fully defined before it is set as a field in RootCommitment.
Update the FetchUnspentPrecommits SQL query to retrieve the full internal key descriptor for pre-commitment outputs. This enables BIP32 derivation when spending these outputs.
ffranr
added
the
supply commit
Pull Request Test Coverage Report for Build 16369238272Details
💛 - Coveralls |
SignAndFinalizePsbt can't currently handle tapd family keys.
FetchSupplyCommit now returns the full key descriptor for the internal key. RootCommitment struct now includes the full internal key descriptor instead of just the public key. This enables specifying BIP32 derivations when spending supply commitment transactions during the creation of a new supply commitment transaction. And also specifying BIP32 derivations in PSBT outputs, and so on.
Add PSBT output with BIP32 derivation. This makes use of the full internal key descriptor that we made available in the previous commit.
When creating a supply commitment transaction, there are two types of inputs that can be spent: * Pre-commitment outputs from mint anchor transactions * Outputs from previous supply commitment transactions This commit adds support for a PSBT input to handle the latter case, allowing spending of a previous supply commitment transaction output.
Ensures the tree construction in the supplycommit package matches the method used in tapdb when storing the tree in the database.
ffranr
force-pushed
the
wip/supplycommit/bugfix-state-machine
branch
from
f2015fe to
dd17a24
Compare
Roasbeef
approved these changes
Jul 21, 2025
| for _, preCommit := range unspentPreCommits { | ||
| newCommitTx.AddTxIn(preCommit.TxIn()) | ||
|
|
||
| bip32Derivation, trBip32Derivation := | ||
| tappsbt.Bip32DerivationFromKeyDesc( |
There was a problem hiding this comment.
Style nit: odd line wrapping here.
universe/supplycommit/transitions.go
Outdated
| // on mint transactions where as the old commitment is the last | ||
| // commitment that was broadcast. | ||
| // | ||
| // TODO(ffranr): Do we have everything we need to fund a PSBT here? |
There was a problem hiding this comment.
TODO maybe addressed in a follow up PR?
| @@ -447,6 +447,21 @@ func newRootCommitment(ctx context.Context, | |||
| } | |||
| } | |||
|
|
|||
| bip32Derivation, trBip32Derivation := | |||
| tappsbt.Bip32DerivationFromKeyDesc( | |||
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards closing: #1534
Multiple small bug fixes for the supply commit state machine.