hack/test-port-forwarding.pl: support socat as listener and writer
#4170
+82
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norio-nomura
force-pushed
the
test-port-forwarding.pl-use-socat
branch
6 times, most recently
from
fe0fed9 to
c18012f
Compare
|
As far as I can see, tests that failed in |
support `socat` as a listener and writer. ```console $ ./hack/test-port-forwarding.pl default [nc|socat] [nc|socat] ``` The `nc` command always sets `SO_REUSEPORT` on the listening TCP port. The `socat` command provides a `reuseport` option that enables `SO_REUSEPORT` on the listening TCP port. Ref: lima-vm#4160 (comment) Signed-off-by: Norio Nomura <[email protected]> hack/test-port-forwarding.pl: Add a connection timeout option and relax it from 1 second to 3 seconds. Signed-off-by: Norio Nomura <[email protected]>
norio-nomura
force-pushed
the
test-port-forwarding.pl-use-socat
branch
from
c18012f to
6eb6232
Compare
… on macOS Signed-off-by: Norio Nomura <[email protected]>
norio-nomura
force-pushed
the
test-port-forwarding.pl-use-socat
branch
from
360a1fb to
124353a
Compare
…nose` Signed-off-by: Norio Nomura <[email protected]>
norio-nomura
force-pushed
the
test-port-forwarding.pl-use-socat
branch
from
76487b1 to
a8100de
Compare
I'm just browsing, but this PR still has failing port forwarding tests, e.g. https://github.com/lima-vm/lima/actions/runs/18364708138/job/52315306508?pr=4170. So it looks like switching to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support
socatas a listener and writer.$ ./hack/test-port-forwarding.pl default [nc|socat] [nc|socat]The
nccommand always setsSO_REUSEPORTon the listening TCP port.The
socatcommand provides areuseportoption that enablesSO_REUSEPORTon the listening TCP port.Ref: #4160 (comment)