Skip to content

TF-4040 Clicking on sender avatar should open contact modal #4041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2025
Merged

TF-4040 Clicking on sender avatar should open contact modal #4041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a18aaf8
TF-4040 Open email modal when clicking on sender avatar
dab246 Sep 23, 2025
21b2ff8
TF-4040 Modal closes when swiping down
dab246 Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/features/email/presentation/email_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,6 @@ class EmailView extends GetWidget<SingleEmailController> {
openPopupMenu: controller.mailboxDashBoardController.openPopupMenu,
),
onToggleThreadDetailCollapseExpand: onToggleThreadDetailCollapseExpand,
onTapAvatarActionClick: onToggleThreadDetailCollapseExpand,
mailboxContain: presentationEmail.findMailboxContain(
controller.mailboxDashBoardController.mapMailboxById,
),
Expand Down
2 changes: 1 addition & 1 deletion lib/features/email/presentation/utils/email_action_reactor/email_action_reactor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,7 @@ class EmailActionReactor {
),
),
isScrollControlled: true,
enableDrag: false,
enableDrag: true,
backgroundColor: Colors.transparent,
);
} else {
Expand Down
12 changes: 8 additions & 4 deletions lib/features/email/presentation/widgets/information_sender_and_receiver_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import 'package:core/presentation/utils/icon_utils.dart';
import 'package:core/presentation/utils/responsive_utils.dart';
import 'package:core/presentation/utils/theme_utils.dart';
import 'package:core/presentation/views/button/tmail_button_widget.dart';
import 'package:core/presentation/views/image/avatar_builder.dart';
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter_svg/flutter_svg.dart';
Expand Down Expand Up @@ -41,7 +40,6 @@ class InformationSenderAndReceiverBuilder extends StatelessWidget {
final OnMoreActionClick? onMoreActionClick;
final bool showRecipients;
final VoidCallback? onToggleThreadDetailCollapseExpand;
final OnTapAvatarActionClick? onTapAvatarActionClick;
final PresentationMailbox? mailboxContain;
final bool showUnreadVisualization;

Expand All @@ -60,7 +58,6 @@ class InformationSenderAndReceiverBuilder extends StatelessWidget {
this.onMoreActionClick,
this.showRecipients = true,
this.onToggleThreadDetailCollapseExpand,
this.onTapAvatarActionClick,
this.mailboxContain,
this.showUnreadVisualization = false,
}) : super(key: key);
Expand All @@ -76,7 +73,14 @@ class InformationSenderAndReceiverBuilder extends StatelessWidget {
children: [
EmailAvatarBuilder(
emailSelected: emailSelected,
onTapAvatarActionClick: onTapAvatarActionClick,
onTapAvatarActionClick: () {
if (emailSelected.from?.isNotEmpty == true) {
openEmailAddressDetailAction?.call(
context,
emailSelected.from!.first,
);
}
},
size: 56,
),
const SizedBox(width: 16),
Expand Down
1 change: 0 additions & 1 deletion lib/features/thread_detail/presentation/widgets/thread_detail_collapsed_email.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ class ThreadDetailCollapsedEmail extends StatelessWidget {
onEmailActionClick: onEmailActionClick,
openEmailAddressDetailAction: openEmailAddressDetailAction,
showRecipients: false,
onTapAvatarActionClick: onToggleThreadDetailCollapseExpand,
mailboxContain: mailboxContain,
showUnreadVisualization: true,
),
Expand Down
Loading