Skip to content

Conversation

DHBR2
Copy link
Collaborator

@DHBR2 DHBR2 commented Aug 12, 2025

This PR manually cherry-picks and commits the corrected MariaDB guide for Debian 12
Renamed guide folder and image from Debian 9 to Debian 12
Removed outdated image
Resolved cherry-pick conflicts and committed cleanly
This PR supersedes #7309 and #7320, which encountered cherry-pick and commit history issues.
Ready for review and merge.

Dianna Hoober added 3 commits August 11, 2025 16:01
… for Debian 1Update2iS C:\Users\dhoober\Documents\docs> git status

On branch mariadb-clean
You are currently cherry-picking commit 4f51b0a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)
Update MariaDB guide for Debian 12
- Renamed guide and image from Debian 9
- Removed outedated image
(cherry-picked from commit 4f51b0a
Changes to be committed:
        renamed:    docs/guides/databases/mariadb/how-to-install-mariadb-on-debian-9/Installing_MariaDB_on_Debian9.png -> docs/guides/databases/mariadb/how-to-install-mariadb-on-debian-12/Installing_MariaDB_on_Debian9.png
        renamed:    docs/guides/databases/mariadb/how-to-install-mariadb-on-debian-9/index.md -> docs/guides/databases/mariadb/how-to-install-mariadb-on-debian-12/index.md

Unmerged paths:
  (use "git rm <file>..." to mark resolution)
        both deleted:    docs/guides/databases/mariadb/how-to-install-mariadb-on-debian-9/Installing_MariaDB_on_Debian12.png
@DHBR2 DHBR2 requested a review from andystevensname August 12, 2025 17:01
DHBR2 and others added 3 commits August 12, 2025 10:25
Fix: format code unix_socket as inline code to resolve Vale warning. Chose Commit directly to the mariadb-clean branch and clicked Commit changes...
Removed trailing space on line 110.
@Rajakavitha1
Copy link
Collaborator

Rajakavitha1 commented Aug 14, 2025

Hi @DHBR2 the Markdown links check is failing because there is a reference to Debian 9 guide. https://www.linode.com/docs/guides/list-tables-in-mysql-and-mariadb/
This link is in the "Before you Begin section" for this test to pass.

@Rajakavitha1 Rajakavitha1 self-requested a review August 14, 2025 11:39
Copy link
Collaborator

@Rajakavitha1 Rajakavitha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rajakavitha1
Copy link
Collaborator

Tested and validated the MariaDB guide on Debian 12
mariadb12.txt

@DHBR2
Copy link
Collaborator Author

DHBR2 commented Aug 14, 2025 via email

@Rajakavitha1
Copy link
Collaborator

So, are you saying that I have to update a different document that is not part of the assigned changes in order to make this PR successful? Let me introduce myself - I work for Andy Stevens as a Technical Writer and am trying to learn the process for getting PRs to pass all checks. The Issue: * The PR is failing a "Markdown links check" * The failure is due to a broken or outdated link to a Debian 9 guide (https://www.linode.com/docs/guides/list-tables-in-mysql-and-mariadb/) * This link exists in the "Before you Begin" section of a document I didn’t modify * Even though this broken link isn't part of my changes, it's causing my PR to fail I’m happy to fix it and add it to the PR, but I wanted to understand if there is an established process for handling this type of situation? My original assignment was to update the one document’s mention of Debian 9 and make relevant changes to the subject matter - no other documentation updates were mentioned. Is fixing unrelated broken links typically the contributor’s responsibility, or is there another way to handle this? From: Rajakavitha Kodhandapani @.> Sent: Thursday, August 14, 2025 4:32 AM To: linode/docs @.> Cc: Hoober, Dianna @.>; Mention @.> Subject: Re: [linode/docs] Clean cherry-pick: MariaDB guide update for Debian 12 (PR #7321) [https://avatars.githubusercontent.com/u/37059749?s=20&v=4]Rajakavitha1 left a comment (linode/docs#7321)https://urldefense.com/v3/__https:/github.com/linode/docs/pull/7321*issuecomment-3188122276__;Iw!!GjvTz_vk!UyH7xlcmZeQ5QjV0rEK7Ku5dv-hU7q9RkYkjuQKdaXNAteT8a_goXcW3rCu6RIdgqmP78I_3xI-pvleuxF_Q5zk$ Hi @DHBR2https://urldefense.com/v3/__https:/github.com/DHBR2__;!!GjvTz_vk!UyH7xlcmZeQ5QjV0rEK7Ku5dv-hU7q9RkYkjuQKdaXNAteT8a_goXcW3rCu6RIdgqmP78I_3xI-pvleumFyGLeo$ the Markdown links check is failing because there is a reference to Debian 9 guide. https://www.linode.com/docs/guides/list-tables-in-mysql-and-mariadb/ This links in the Before you Begin section for this test to pass. — Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/linode/docs/pull/7321*issuecomment-3188122276__;Iw!!GjvTz_vk!UyH7xlcmZeQ5QjV0rEK7Ku5dv-hU7q9RkYkjuQKdaXNAteT8a_goXcW3rCu6RIdgqmP78I_3xI-pvleuxF_Q5zk$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BTI6GIXXU2YVLIQFMRQZDCT3NRXS3AVCNFSM6AAAAACDXDFUPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOBYGEZDEMRXGY__;!!GjvTz_vk!UyH7xlcmZeQ5QjV0rEK7Ku5dv-hU7q9RkYkjuQKdaXNAteT8a_goXcW3rCu6RIdgqmP78I_3xI-pvleu07_kIwU$. You are receiving this because you were mentioned.Message ID: @.@.>>

Hi @DHBR2
Just made the updates to the format you can see the format changes in the commits.
I also made changes in the related files so that the CI/CD tests are successful.

Copy link
Collaborator

@Rajakavitha1 Rajakavitha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rajakavitha1
Copy link
Collaborator

LGTM

Screenshot 2025-08-15 at 11 35 12 AM

@Rajakavitha1
Copy link
Collaborator

Rajakavitha1 commented Aug 15, 2025

LGTM

Screenshot 2025-08-15 at 11 35 12 AM

Hi @andystevensname
I have tested and validated please review the changes.
Also not sure if this file is required. docs/guides/databases/mariadb/how-to-install-mariadb-on-debian-12/Installing_MariaDB_on_Debian9.png. Please let me know know if this can be deleted for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants