Exclude Mint.HTTP module from warnings

[aleDsz]

==> kino_db
Compiling 4 files (.ex)
warning: Mint.HTTP.connect/3 is undefined (module Mint.HTTP is not available or is yet to be defined)
  lib/kino_db/connection_cell.ex:395: KinoDB.ConnectionCell.running_on_google_metadata?/0

warning: Mint.HTTP.set_mode/2 is undefined (module Mint.HTTP is not available or is yet to be defined)
  lib/kino_db/connection_cell.ex:396: KinoDB.ConnectionCell.running_on_google_metadata?/0

Generated kino_db app

[josevalim]

Wait, do we use @compile {:no_warn_undefined, ...} anywhere else in this project. If so, perhaps we should do the same in KinoDB.ConnectionCell. Otherwise this patch is good to go!

[wojtekmach]

Yeah, we have one occurrence:

lib/kino_db/sql_cell.ex
113:  @compile {:no_warn_undefined, {DBConnection, :connection_module, 1}}

+1 on standardising either way. :)

[wojtekmach]

this should be two lines like you previously had:

Suggested change

	@compile {:no_warn_undefined, {Mint.HTTP, :connect, 3}, {Mint.HTTP, :set_mode, 2}}
	@compile {:no_warn_undefined, {Mint.HTTP, :connect, 3}}
	@compile {:no_warn_undefined, {Mint.HTTP, :set_mode, 2}}

pro-tip, the way I tested it was:

$ elixir -e 'Mix.install [{:kino_db, path: "~/src/kino_db"}], force: true'

[jonatanklosko]

Or mix compile --force --no-optional-deps 🐱

[wojtekmach]

nice, forgot about that one. we should add it to CI if we don't have it already :D

[jonatanklosko]

Good call, @aleDsz feel free to add as part of this PR :)

[aleDsz]

With mix compile --warnings-as-errors --force --no-optional-deps it still fails

[wojtekmach]

Yeah, this seems like a bug. I noticed with [xref: [exclude: [Mint.HTTP]] it works correctly but with @compile ... I'm getting:

~/src/kino_db[main]% mix compile --warnings-as-errors --no-optional-deps --force
Compiling 4 files (.ex)
warning: Mint.HTTP.connect/3 defined in application :mint is used by the current application but the current application does not depend on :mint. To fix this, you must do one of:

  1. If :mint is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :mint is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :mint, you may optionally skip this warning by adding [xref: [exclude: [Mint.HTTP]]] to your "def project" in mix.exs

  lib/kino_db/connection_cell.ex:398: KinoDB.ConnectionCell.running_on_google_metadata?/0

warning: Mint.HTTP.set_mode/2 defined in application :mint is used by the current application but the current application does not depend on :mint. To fix this, you must do one of:

  1. If :mint is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :mint is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :mint, you may optionally skip this warning by adding [xref: [exclude: [Mint.HTTP]]] to your "def project" in mix.exs

  lib/kino_db/connection_cell.ex:399: KinoDB.ConnectionCell.running_on_google_metadata?/0

Compilation failed due to warnings while using the --warnings-as-errors option

For anyone else testing this locally, first do rm -rf _build. :)

[aleDsz]

That's odd, because DBConnection doesn't fail