fix Speech interruption attempted when allow_interruption is False #3238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
longcw
reviewed
Aug 25, 2025
| if self._user_turn_completed_atask != asyncio.current_task(): | ||
| if ( | ||
| self._user_turn_completed_atask != asyncio.current_task() | ||
| and not speech_handle._allow_interruptions |
There was a problem hiding this comment.
should we cancel the speech in this case? cc @theomonnom
There was a problem hiding this comment.
IMO manual interruption should always be allowed..
allow_interruption should be referencing if a user is able to interrupt via voice
There was a problem hiding this comment.
Another PR added force=True to the interrupt method.
There was a problem hiding this comment.
Otherwise I think this PR makes sense, but shouldn't it be the opposite? We check if interruptions is allowed, not disallowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3230