feat(projects): start storing ID on project credentials #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let us auto-select (and if we want, auto-accept) a project when user provides the project ID in advance.
yoonsio
reviewed
Aug 22, 2025
|
@yoonsio we don't backfill existing configured projects, just new auths from now on. If you want I can add a check and backfill if any project doesn't have an ID whenever config file is read? But we need new API for it. |
bcherry
reviewed
Aug 22, 2025
| @@ -271,6 +276,7 @@ func tryAuthIfNeeded(ctx context.Context, cmd *cli.Command) error { | |||
| // get devicename | |||
| if err := huh.NewInput(). | |||
| Title("What is the name of this device?"). | |||
| Description("A short name you can use to find and manage generated API keys on the LiveKit Cloud dashboard"). | |||
bcherry
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/livekit/issue/DPRO-461/save-project-id-in-cli-credentials
lk cloud auth <project_id>, which when backend support is added, will let us pre-select (and automatically confirm) project to authenticate.