RuntimeLibcalls: Stop using defset for default calls

[arsenm]

This is redundant with the IsDefault field, so avoid a really
long enclosing pair of braces. This will make it easier to gradually
remove calls from the default set.

[arsenm]

• RuntimeLibcalls: Avoid adding f80 calls to default set #147658
• RuntimeLibcalls: Avoid adding ppcf128 calls to non-ppc targets #147656
• RISCV: Start moving runtime libcall config to tablegen #147652
• RuntimeLibcalls: Stop using defset for default calls #147651 👈 (View in Graphite)
• Hexagon: Move runtime libcall configuration to tablegen #147482
• DAG: Use fast variants of fast math libcalls #147481
• ARM: Start moving runtime libcalls into tablegen #146084
• ARM: Unconditionally set eabi libcall calling convs in RuntimeLibcalls #146083
• RuntimeLibcalls: Remove table of soft float compare cond codes #146082
• MSP430: Move libcall CC setting to RuntimeLibcallsInfo #146081
• Lanai: Use TableGen to set libcall calling conventions #146080
• TableGen: Handle setting runtime libcall calling conventions #144980
• RuntimeLibcalls: Associate calling convention with libcall impls #144979
• TableGen: Allow defining sets of runtime libraries #144978
• AArch64: Add libcall impl declarations for __arm_sc* memory functions #144977
• XCore: Declare libcalls used for align 4 memcpy #144976
• Hexagon: Add libcall declarations for special memcpy #144975
• ARM: Add runtime libcall definitions for aebi memory functions #144974
• TableGen: Generate enum for runtime libcall implementations #144973
• TableGen: Add runtime libcall backend #144972
• PowerPC: Stop reporting memcpy as an alias of memmove on AIX #143836
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-llvm-selectiondag
@llvm/pr-subscribers-llvm-ir

@llvm/pr-subscribers-backend-hexagon

Author: Matt Arsenault (arsenm)

Changes

This is redundant with the IsDefault field, so avoid a really
long enclosing pair of braces. This will make it easier to gradually
remove calls from the default set.

---

Full diff: https://github.com/llvm/llvm-project/pull/147651.diff

1 Files Affected:

• (modified) llvm/include/llvm/IR/RuntimeLibcalls.td (+2-4)

diff --git a/llvm/include/llvm/IR/RuntimeLibcalls.td b/llvm/include/llvm/IR/RuntimeLibcalls.td
index 61b082b8a6101..ee4892ee186cd 100644
--- a/llvm/include/llvm/IR/RuntimeLibcalls.td
+++ b/llvm/include/llvm/IR/RuntimeLibcalls.td
@@ -402,7 +402,6 @@ def MEMCPY_ALIGN_4 : RuntimeLibcall;
 // Define implementation default libcalls
 //--------------------------------------------------------------------
 
-defset list<RuntimeLibcallImpl> AllDefaultRuntimeLibcallImpls = {
 let IsDefault = true in {
 
 //--------------------------------------------------------------------
@@ -908,7 +907,6 @@ def memset : RuntimeLibcallImpl<MEMSET>;
 def calloc : RuntimeLibcallImpl<CALLOC>;
 
 } // End let IsDefault = true
-} // End defset AllDefaultRuntimeLibcallImpls
 
 //--------------------------------------------------------------------
 // Define implementation other libcalls
@@ -999,8 +997,8 @@ defset list<RuntimeLibcallImpl> LibmF128FiniteLibcalls = {
 // unreasonable defaults like reporting f80 calls on most targets when
 // they are relevant to only one.
 
-defvar AllDefaultLibCalls =
-    !foreach(entry, AllDefaultRuntimeLibcallImpls, entry.Provides);
+defvar AllDefaultRuntimeLibcallImpls
+  = !filter(entry, !instances<RuntimeLibcallImpl>(), entry.IsDefault);
 
 // Exist in libgcc and compiler-rt for 64-bit targets, or if
 // COMPILER_RT_ENABLE_SOFTWARE_INT128.

[arsenm]

Merge activity

• Jul 13, 1:37 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jul 13, 1:45 AM UTC: Graphite rebased this pull request as part of a merge.
• Jul 13, 1:47 AM UTC: @arsenm merged this pull request with Graphite.