Skip to content

[libc++] Move a bunch of extensions tests to test/extensions #149275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[libc++] Move a bunch of extensions tests to test/extensions #149275

wants to merge 1 commit into from
+0 −0

Conversation

philnik777
Copy link
Contributor

No description provided.

@philnik777 philnik777 requested a review from a team as a code owner July 17, 2025 08:55
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jul 17, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 17, 2025

@llvm/pr-subscribers-libcxx

Author: Nikolas Klauser (philnik777)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/149275.diff

15 Files Affected:

  • (renamed) libcxx/test/extensions/gnu/hash_map/hash_map.pass.cpp ()
  • (renamed) libcxx/test/extensions/gnu/hash_map/hash_map_name_lookup.pass.cpp ()
  • (renamed) libcxx/test/extensions/gnu/hash_set/hash_set.pass.cpp ()
  • (renamed) libcxx/test/extensions/gnu/hash_set/hash_set_name_lookup.pass.cpp ()
  • (renamed) libcxx/test/extensions/libcxx/atomics/atomics.flag/init_bool.pass.cpp ()
  • (renamed) libcxx/test/extensions/libcxx/containers/associative/map/scary.compile.pass.cpp ()
  • (renamed) libcxx/test/extensions/libcxx/containers/associative/set/scary.compile.pass.cpp ()
  • (renamed) libcxx/test/extensions/libcxx/containers/associative/unord.map/scary.compile.pass.cpp ()
  • (renamed) libcxx/test/extensions/libcxx/containers/associative/unord.set/scary.compile.pass.cpp ()
  • (renamed) libcxx/test/extensions/libcxx/containers/sequences/deque/incomplete.pass.cpp ()
  • (renamed) libcxx/test/extensions/libcxx/depr/depr.c.headers/extern_c.pass.cpp ()
  • (renamed) libcxx/test/extensions/libcxx/depr/depr.c.headers/include_as_c.sh.cpp ()
  • (renamed) libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.std_types_t.compile.pass.cpp ()
  • (renamed) libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.xopen_source.compile.pass.cpp ()
  • (renamed) libcxx/test/extensions/msvc/math_h.compile.pass.cpp ()
diff --git a/libcxx/test/libcxx/containers/gnu_cxx/hash_map.pass.cpp b/libcxx/test/extensions/gnu/hash_map/hash_map.pass.cpp
similarity index 100%
rename from libcxx/test/libcxx/containers/gnu_cxx/hash_map.pass.cpp
rename to libcxx/test/extensions/gnu/hash_map/hash_map.pass.cpp
diff --git a/libcxx/test/libcxx/containers/gnu_cxx/hash_map_name_lookup.pass.cpp b/libcxx/test/extensions/gnu/hash_map/hash_map_name_lookup.pass.cpp
similarity index 100%
rename from libcxx/test/libcxx/containers/gnu_cxx/hash_map_name_lookup.pass.cpp
rename to libcxx/test/extensions/gnu/hash_map/hash_map_name_lookup.pass.cpp
diff --git a/libcxx/test/libcxx/containers/gnu_cxx/hash_set.pass.cpp b/libcxx/test/extensions/gnu/hash_set/hash_set.pass.cpp
similarity index 100%
rename from libcxx/test/libcxx/containers/gnu_cxx/hash_set.pass.cpp
rename to libcxx/test/extensions/gnu/hash_set/hash_set.pass.cpp
diff --git a/libcxx/test/libcxx/containers/gnu_cxx/hash_set_name_lookup.pass.cpp b/libcxx/test/extensions/gnu/hash_set/hash_set_name_lookup.pass.cpp
similarity index 100%
rename from libcxx/test/libcxx/containers/gnu_cxx/hash_set_name_lookup.pass.cpp
rename to libcxx/test/extensions/gnu/hash_set/hash_set_name_lookup.pass.cpp
diff --git a/libcxx/test/libcxx/atomics/atomics.flag/init_bool.pass.cpp b/libcxx/test/extensions/libcxx/atomics/atomics.flag/init_bool.pass.cpp
similarity index 100%
rename from libcxx/test/libcxx/atomics/atomics.flag/init_bool.pass.cpp
rename to libcxx/test/extensions/libcxx/atomics/atomics.flag/init_bool.pass.cpp
diff --git a/libcxx/test/libcxx/containers/associative/map/scary.compile.pass.cpp b/libcxx/test/extensions/libcxx/containers/associative/map/scary.compile.pass.cpp
similarity index 100%
rename from libcxx/test/libcxx/containers/associative/map/scary.compile.pass.cpp
rename to libcxx/test/extensions/libcxx/containers/associative/map/scary.compile.pass.cpp
diff --git a/libcxx/test/libcxx/containers/associative/set/scary.compile.pass.cpp b/libcxx/test/extensions/libcxx/containers/associative/set/scary.compile.pass.cpp
similarity index 100%
rename from libcxx/test/libcxx/containers/associative/set/scary.compile.pass.cpp
rename to libcxx/test/extensions/libcxx/containers/associative/set/scary.compile.pass.cpp
diff --git a/libcxx/test/libcxx/containers/associative/unord.map/scary.compile.pass.cpp b/libcxx/test/extensions/libcxx/containers/associative/unord.map/scary.compile.pass.cpp
similarity index 100%
rename from libcxx/test/libcxx/containers/associative/unord.map/scary.compile.pass.cpp
rename to libcxx/test/extensions/libcxx/containers/associative/unord.map/scary.compile.pass.cpp
diff --git a/libcxx/test/libcxx/containers/associative/unord.set/scary.compile.pass.cpp b/libcxx/test/extensions/libcxx/containers/associative/unord.set/scary.compile.pass.cpp
similarity index 100%
rename from libcxx/test/libcxx/containers/associative/unord.set/scary.compile.pass.cpp
rename to libcxx/test/extensions/libcxx/containers/associative/unord.set/scary.compile.pass.cpp
diff --git a/libcxx/test/libcxx/containers/sequences/deque/incomplete.pass.cpp b/libcxx/test/extensions/libcxx/containers/sequences/deque/incomplete.pass.cpp
similarity index 100%
rename from libcxx/test/libcxx/containers/sequences/deque/incomplete.pass.cpp
rename to libcxx/test/extensions/libcxx/containers/sequences/deque/incomplete.pass.cpp
diff --git a/libcxx/test/libcxx/depr/depr.c.headers/extern_c.pass.cpp b/libcxx/test/extensions/libcxx/depr/depr.c.headers/extern_c.pass.cpp
similarity index 100%
rename from libcxx/test/libcxx/depr/depr.c.headers/extern_c.pass.cpp
rename to libcxx/test/extensions/libcxx/depr/depr.c.headers/extern_c.pass.cpp
diff --git a/libcxx/test/extensions/libcxx/include_as_c.sh.cpp b/libcxx/test/extensions/libcxx/depr/depr.c.headers/include_as_c.sh.cpp
similarity index 100%
rename from libcxx/test/extensions/libcxx/include_as_c.sh.cpp
rename to libcxx/test/extensions/libcxx/depr/depr.c.headers/include_as_c.sh.cpp
diff --git a/libcxx/test/libcxx/depr/depr.c.headers/stdint_h.std_types_t.compile.pass.cpp b/libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.std_types_t.compile.pass.cpp
similarity index 100%
rename from libcxx/test/libcxx/depr/depr.c.headers/stdint_h.std_types_t.compile.pass.cpp
rename to libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.std_types_t.compile.pass.cpp
diff --git a/libcxx/test/libcxx/depr/depr.c.headers/stdint_h.xopen_source.compile.pass.cpp b/libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.xopen_source.compile.pass.cpp
similarity index 100%
rename from libcxx/test/libcxx/depr/depr.c.headers/stdint_h.xopen_source.compile.pass.cpp
rename to libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.xopen_source.compile.pass.cpp
diff --git a/libcxx/test/libcxx/depr/depr.c.headers/math_h.compile.pass.cpp b/libcxx/test/extensions/msvc/math_h.compile.pass.cpp
similarity index 100%
rename from libcxx/test/libcxx/depr/depr.c.headers/math_h.compile.pass.cpp
rename to libcxx/test/extensions/msvc/math_h.compile.pass.cpp

@github-actions GitHub Actions
Copy link

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command: 
git-clang-format --diff HEAD~1 HEAD --extensions cpp -- libcxx/test/extensions/gnu/hash_map/hash_map.pass.cpp libcxx/test/extensions/gnu/hash_map/hash_map_name_lookup.pass.cpp libcxx/test/extensions/gnu/hash_set/hash_set.pass.cpp libcxx/test/extensions/gnu/hash_set/hash_set_name_lookup.pass.cpp libcxx/test/extensions/libcxx/atomics/atomics.flag/init_bool.pass.cpp libcxx/test/extensions/libcxx/containers/associative/map/scary.compile.pass.cpp libcxx/test/extensions/libcxx/containers/associative/set/scary.compile.pass.cpp libcxx/test/extensions/libcxx/containers/associative/unord.map/scary.compile.pass.cpp libcxx/test/extensions/libcxx/containers/associative/unord.set/scary.compile.pass.cpp libcxx/test/extensions/libcxx/containers/sequences/deque/incomplete.pass.cpp libcxx/test/extensions/libcxx/depr/depr.c.headers/extern_c.pass.cpp libcxx/test/extensions/libcxx/depr/depr.c.headers/include_as_c.sh.cpp libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.std_types_t.compile.pass.cpp libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.xopen_source.compile.pass.cpp libcxx/test/extensions/msvc/math_h.compile.pass.cpp
View the diff from clang-format here. 
diff --git a/libcxx/test/extensions/libcxx/atomics/atomics.flag/init_bool.pass.cpp b/libcxx/test/extensions/libcxx/atomics/atomics.flag/init_bool.pass.cpp
index 767877552..be8409208 100644
--- a/libcxx/test/extensions/libcxx/atomics/atomics.flag/init_bool.pass.cpp
+++ b/libcxx/test/extensions/libcxx/atomics/atomics.flag/init_bool.pass.cpp
@@ -20,24 +20,25 @@
 #if TEST_STD_VER >= 11
 // Ensure that static initialization happens; this is PR#37226
 extern std::atomic_flag global;
-struct X { X() { global.test_and_set(); }};
+struct X {
+  X() { global.test_and_set(); }
+};
 X x;
 std::atomic_flag global{false};
 #endif
 
-int main(int, char**)
-{
+int main(int, char**) {
 #if TEST_STD_VER >= 11
-    assert(global.test_and_set() == 1);
+  assert(global.test_and_set() == 1);
 #endif
-    {
-        std::atomic_flag f(false);
-        assert(f.test_and_set() == 0);
-    }
-    {
-        std::atomic_flag f(true);
-        assert(f.test_and_set() == 1);
-    }
+  {
+    std::atomic_flag f(false);
+    assert(f.test_and_set() == 0);
+  }
+  {
+    std::atomic_flag f(true);
+    assert(f.test_and_set() == 1);
+  }
 
   return 0;
 }
diff --git a/libcxx/test/extensions/libcxx/depr/depr.c.headers/extern_c.pass.cpp b/libcxx/test/extensions/libcxx/depr/depr.c.headers/extern_c.pass.cpp
index f756aacbc..deda27767 100644
--- a/libcxx/test/extensions/libcxx/depr/depr.c.headers/extern_c.pass.cpp
+++ b/libcxx/test/extensions/libcxx/depr/depr.c.headers/extern_c.pass.cpp
@@ -48,6 +48,4 @@ extern "C" {
 #endif
 }
 
-int main(int, char**) {
-  return 0;
-}
+int main(int, char**) { return 0; }
diff --git a/libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.std_types_t.compile.pass.cpp b/libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.std_types_t.compile.pass.cpp
index 3485ce755..150b6317c 100644
--- a/libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.std_types_t.compile.pass.cpp
+++ b/libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.std_types_t.compile.pass.cpp
@@ -14,250 +14,250 @@
 // https://reviews.llvm.org/D59253
 
 #define _STD_TYPES_T
-#   include <stdint.h>
+#include <stdint.h>
 #undef _STD_TYPES_T
 #include <stdint.h>
 
 #ifndef INT8_MIN
-#error INT8_MIN not defined
+#  error INT8_MIN not defined
 #endif
 
 #ifndef INT16_MIN
-#error INT16_MIN not defined
+#  error INT16_MIN not defined
 #endif
 
 #ifndef INT32_MIN
-#error INT32_MIN not defined
+#  error INT32_MIN not defined
 #endif
 
 #ifndef INT64_MIN
-#error INT64_MIN not defined
+#  error INT64_MIN not defined
 #endif
 
 #ifndef INT8_MAX
-#error INT8_MAX not defined
+#  error INT8_MAX not defined
 #endif
 
 #ifndef INT16_MAX
-#error INT16_MAX not defined
+#  error INT16_MAX not defined
 #endif
 
 #ifndef INT32_MAX
-#error INT32_MAX not defined
+#  error INT32_MAX not defined
 #endif
 
 #ifndef INT64_MAX
-#error INT64_MAX not defined
+#  error INT64_MAX not defined
 #endif
 
 #ifndef UINT8_MAX
-#error UINT8_MAX not defined
+#  error UINT8_MAX not defined
 #endif
 
 #ifndef UINT16_MAX
-#error UINT16_MAX not defined
+#  error UINT16_MAX not defined
 #endif
 
 #ifndef UINT32_MAX
-#error UINT32_MAX not defined
+#  error UINT32_MAX not defined
 #endif
 
 #ifndef UINT64_MAX
-#error UINT64_MAX not defined
+#  error UINT64_MAX not defined
 #endif
 
 #ifndef INT_LEAST8_MIN
-#error INT_LEAST8_MIN not defined
+#  error INT_LEAST8_MIN not defined
 #endif
 
 #ifndef INT_LEAST16_MIN
-#error INT_LEAST16_MIN not defined
+#  error INT_LEAST16_MIN not defined
 #endif
 
 #ifndef INT_LEAST32_MIN
-#error INT_LEAST32_MIN not defined
+#  error INT_LEAST32_MIN not defined
 #endif
 
 #ifndef INT_LEAST64_MIN
-#error INT_LEAST64_MIN not defined
+#  error INT_LEAST64_MIN not defined
 #endif
 
 #ifndef INT_LEAST8_MAX
-#error INT_LEAST8_MAX not defined
+#  error INT_LEAST8_MAX not defined
 #endif
 
 #ifndef INT_LEAST16_MAX
-#error INT_LEAST16_MAX not defined
+#  error INT_LEAST16_MAX not defined
 #endif
 
 #ifndef INT_LEAST32_MAX
-#error INT_LEAST32_MAX not defined
+#  error INT_LEAST32_MAX not defined
 #endif
 
 #ifndef INT_LEAST64_MAX
-#error INT_LEAST64_MAX not defined
+#  error INT_LEAST64_MAX not defined
 #endif
 
 #ifndef UINT_LEAST8_MAX
-#error UINT_LEAST8_MAX not defined
+#  error UINT_LEAST8_MAX not defined
 #endif
 
 #ifndef UINT_LEAST16_MAX
-#error UINT_LEAST16_MAX not defined
+#  error UINT_LEAST16_MAX not defined
 #endif
 
 #ifndef UINT_LEAST32_MAX
-#error UINT_LEAST32_MAX not defined
+#  error UINT_LEAST32_MAX not defined
 #endif
 
 #ifndef UINT_LEAST64_MAX
-#error UINT_LEAST64_MAX not defined
+#  error UINT_LEAST64_MAX not defined
 #endif
 
 #ifndef INT_FAST8_MIN
-#error INT_FAST8_MIN not defined
+#  error INT_FAST8_MIN not defined
 #endif
 
 #ifndef INT_FAST16_MIN
-#error INT_FAST16_MIN not defined
+#  error INT_FAST16_MIN not defined
 #endif
 
 #ifndef INT_FAST32_MIN
-#error INT_FAST32_MIN not defined
+#  error INT_FAST32_MIN not defined
 #endif
 
 #ifndef INT_FAST64_MIN
-#error INT_FAST64_MIN not defined
+#  error INT_FAST64_MIN not defined
 #endif
 
 #ifndef INT_FAST8_MAX
-#error INT_FAST8_MAX not defined
+#  error INT_FAST8_MAX not defined
 #endif
 
 #ifndef INT_FAST16_MAX
-#error INT_FAST16_MAX not defined
+#  error INT_FAST16_MAX not defined
 #endif
 
 #ifndef INT_FAST32_MAX
-#error INT_FAST32_MAX not defined
+#  error INT_FAST32_MAX not defined
 #endif
 
 #ifndef INT_FAST64_MAX
-#error INT_FAST64_MAX not defined
+#  error INT_FAST64_MAX not defined
 #endif
 
 #ifndef UINT_FAST8_MAX
-#error UINT_FAST8_MAX not defined
+#  error UINT_FAST8_MAX not defined
 #endif
 
 #ifndef UINT_FAST16_MAX
-#error UINT_FAST16_MAX not defined
+#  error UINT_FAST16_MAX not defined
 #endif
 
 #ifndef UINT_FAST32_MAX
-#error UINT_FAST32_MAX not defined
+#  error UINT_FAST32_MAX not defined
 #endif
 
 #ifndef UINT_FAST64_MAX
-#error UINT_FAST64_MAX not defined
+#  error UINT_FAST64_MAX not defined
 #endif
 
 #ifndef INTPTR_MIN
-#error INTPTR_MIN not defined
+#  error INTPTR_MIN not defined
 #endif
 
 #ifndef INTPTR_MAX
-#error INTPTR_MAX not defined
+#  error INTPTR_MAX not defined
 #endif
 
 #ifndef UINTPTR_MAX
-#error UINTPTR_MAX not defined
+#  error UINTPTR_MAX not defined
 #endif
 
 #ifndef INTMAX_MIN
-#error INTMAX_MIN not defined
+#  error INTMAX_MIN not defined
 #endif
 
 #ifndef INTMAX_MAX
-#error INTMAX_MAX not defined
+#  error INTMAX_MAX not defined
 #endif
 
 #ifndef UINTMAX_MAX
-#error UINTMAX_MAX not defined
+#  error UINTMAX_MAX not defined
 #endif
 
 #ifndef PTRDIFF_MIN
-#error PTRDIFF_MIN not defined
+#  error PTRDIFF_MIN not defined
 #endif
 
 #ifndef PTRDIFF_MAX
-#error PTRDIFF_MAX not defined
+#  error PTRDIFF_MAX not defined
 #endif
 
 #ifndef SIG_ATOMIC_MIN
-#error SIG_ATOMIC_MIN not defined
+#  error SIG_ATOMIC_MIN not defined
 #endif
 
 #ifndef SIG_ATOMIC_MAX
-#error SIG_ATOMIC_MAX not defined
+#  error SIG_ATOMIC_MAX not defined
 #endif
 
 #ifndef SIZE_MAX
-#error SIZE_MAX not defined
+#  error SIZE_MAX not defined
 #endif
 
 #ifndef WCHAR_MIN
-#error WCHAR_MIN not defined
+#  error WCHAR_MIN not defined
 #endif
 
 #ifndef WCHAR_MAX
-#error WCHAR_MAX not defined
+#  error WCHAR_MAX not defined
 #endif
 
 #ifndef WINT_MIN
-#error WINT_MIN not defined
+#  error WINT_MIN not defined
 #endif
 
 #ifndef WINT_MAX
-#error WINT_MAX not defined
+#  error WINT_MAX not defined
 #endif
 
 #ifndef INT8_C
-#error INT8_C not defined
+#  error INT8_C not defined
 #endif
 
 #ifndef INT16_C
-#error INT16_C not defined
+#  error INT16_C not defined
 #endif
 
 #ifndef INT32_C
-#error INT32_C not defined
+#  error INT32_C not defined
 #endif
 
 #ifndef INT64_C
-#error INT64_C not defined
+#  error INT64_C not defined
 #endif
 
 #ifndef UINT8_C
-#error UINT8_C not defined
+#  error UINT8_C not defined
 #endif
 
 #ifndef UINT16_C
-#error UINT16_C not defined
+#  error UINT16_C not defined
 #endif
 
 #ifndef UINT32_C
-#error UINT32_C not defined
+#  error UINT32_C not defined
 #endif
 
 #ifndef UINT64_C
-#error UINT64_C not defined
+#  error UINT64_C not defined
 #endif
 
 #ifndef INTMAX_C
-#error INTMAX_C not defined
+#  error INTMAX_C not defined
 #endif
 
 #ifndef UINTMAX_C
-#error UINTMAX_C not defined
+#  error UINTMAX_C not defined
 #endif
diff --git a/libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.xopen_source.compile.pass.cpp b/libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.xopen_source.compile.pass.cpp
index 75a4ab908..ef59f7c92 100644
--- a/libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.xopen_source.compile.pass.cpp
+++ b/libcxx/test/extensions/libcxx/depr/depr.c.headers/stdint_h.xopen_source.compile.pass.cpp
@@ -19,245 +19,245 @@
 #include <stdint.h>
 
 #ifndef INT8_MIN
-#error INT8_MIN not defined
+#  error INT8_MIN not defined
 #endif
 
 #ifndef INT16_MIN
-#error INT16_MIN not defined
+#  error INT16_MIN not defined
 #endif
 
 #ifndef INT32_MIN
-#error INT32_MIN not defined
+#  error INT32_MIN not defined
 #endif
 
 #ifndef INT64_MIN
-#error INT64_MIN not defined
+#  error INT64_MIN not defined
 #endif
 
 #ifndef INT8_MAX
-#error INT8_MAX not defined
+#  error INT8_MAX not defined
 #endif
 
 #ifndef INT16_MAX
-#error INT16_MAX not defined
+#  error INT16_MAX not defined
 #endif
 
 #ifndef INT32_MAX
-#error INT32_MAX not defined
+#  error INT32_MAX not defined
 #endif
 
 #ifndef INT64_MAX
-#error INT64_MAX not defined
+#  error INT64_MAX not defined
 #endif
 
 #ifndef UINT8_MAX
-#error UINT8_MAX not defined
+#  error UINT8_MAX not defined
 #endif
 
 #ifndef UINT16_MAX
-#error UINT16_MAX not defined
+#  error UINT16_MAX not defined
 #endif
 
 #ifndef UINT32_MAX
-#error UINT32_MAX not defined
+#  error UINT32_MAX not defined
 #endif
 
 #ifndef UINT64_MAX
-#error UINT64_MAX not defined
+#  error UINT64_MAX not defined
 #endif
 
 #ifndef INT_LEAST8_MIN
-#error INT_LEAST8_MIN not defined
+#  error INT_LEAST8_MIN not defined
 #endif
 
 #ifndef INT_LEAST16_MIN
-#error INT_LEAST16_MIN not defined
+#  error INT_LEAST16_MIN not defined
 #endif
 
 #ifndef INT_LEAST32_MIN
-#error INT_LEAST32_MIN not defined
+#  error INT_LEAST32_MIN not defined
 #endif
 
 #ifndef INT_LEAST64_MIN
-#error INT_LEAST64_MIN not defined
+#  error INT_LEAST64_MIN not defined
 #endif
 
 #ifndef INT_LEAST8_MAX
-#error INT_LEAST8_MAX not defined
+#  error INT_LEAST8_MAX not defined
 #endif
 
 #ifndef INT_LEAST16_MAX
-#error INT_LEAST16_MAX not defined
+#  error INT_LEAST16_MAX not defined
 #endif
 
 #ifndef INT_LEAST32_MAX
-#error INT_LEAST32_MAX not defined
+#  error INT_LEAST32_MAX not defined
 #endif
 
 #ifndef INT_LEAST64_MAX
-#error INT_LEAST64_MAX not defined
+#  error INT_LEAST64_MAX not defined
 #endif
 
 #ifndef UINT_LEAST8_MAX
-#error UINT_LEAST8_MAX not defined
+#  error UINT_LEAST8_MAX not defined
 #endif
 
 #ifndef UINT_LEAST16_MAX
-#error UINT_LEAST16_MAX not defined
+#  error UINT_LEAST16_MAX not defined
 #endif
 
 #ifndef UINT_LEAST32_MAX
-#error UINT_LEAST32_MAX not defined
+#  error UINT_LEAST32_MAX not defined
 #endif
 
 #ifndef UINT_LEAST64_MAX
-#error UINT_LEAST64_MAX not defined
+#  error UINT_LEAST64_MAX not defined
 #endif
 
 #ifndef INT_FAST8_MIN
-#error INT_FAST8_MIN not defined
+#  error INT_FAST8_MIN not defined
 #endif
 
 #ifndef INT_FAST16_MIN
-#error INT_FAST16_MIN not defined
+#  error INT_FAST16_MIN not defined
 #endif
 
 #ifndef INT_FAST32_MIN
-#error INT_FAST32_MIN not defined
+#  error INT_FAST32_MIN not defined
 #endif
 
 #ifndef INT_FAST64_MIN
-#error INT_FAST64_MIN not defined
+#  error INT_FAST64_MIN not defined
 #endif
 
 #ifndef INT_FAST8_MAX
-#error INT_FAST8_MAX not defined
+#  error INT_FAST8_MAX not defined
 #endif
 
 #ifndef INT_FAST16_MAX
-#error INT_FAST16_MAX not defined
+#  error INT_FAST16_MAX not defined
 #endif
 
 #ifndef INT_FAST32_MAX
-#error INT_FAST32_MAX not defined
+#  error INT_FAST32_MAX not defined
 #endif
 
 #ifndef INT_FAST64_MAX
-#error INT_FAST64_MAX not defined
+#  error INT_FAST64_MAX not defined
 #endif
 
 #ifndef UINT_FAST8_MAX
-#error UINT_FAST8_MAX not defined
+#  error UINT_FAST8_MAX not defined
 #endif
 
 #ifndef UINT_FAST16_MAX
-#error UINT_FAST16_MAX not defined
+#  error UINT_FAST16_MAX not defined
 #endif
 
 #ifndef UINT_FAST32_MAX
-#error UINT_FAST32_MAX not defined
+#  error UINT_FAST32_MAX not defined
 #endif
 
 #ifndef UINT_FAST64_MAX
-#error UINT_FAST64_MAX not defined
+#  error UINT_FAST64_MAX not defined
 #endif
 
 #ifndef INTPTR_MIN
-#error INTPTR_MIN not defined
+#  error INTPTR_MIN not defined
 #endif
 
 #ifndef INTPTR_MAX
-#error INTPTR_MAX not defined
+#  error INTPTR_MAX not defined
 #endif
 
 #ifndef UINTPTR_MAX
-#error UINTPTR_MAX not defined
+#  error UINTPTR_MAX not defined
 #endif
 
 #ifndef INTMAX_MIN
-#error INTMAX_MIN not defined
+#  error INTMAX_MIN not defined
 #endif
 
 #ifndef INTMAX_MAX
-#error INTMAX_MAX not defined
+#  error INTMAX_MAX not defined
 #endif
 
 #ifndef UINTMAX_MAX
-#error UINTMAX_MAX not defined
+#  error UINTMAX_MAX not defined
 #endif
 
 #ifndef PTRDIFF_MIN
-#error PTRDIFF_MIN not defined
+#  error PTRDIFF_MIN not defined
 #endif
 
 #ifndef PTRDIFF_MAX
-#error PTRDIFF_MAX not defined
+#  error PTRDIFF_MAX not defined
 #endif
 
 #ifndef SIG_ATOMIC_MIN
-#error SIG_ATOMIC_MIN not defined
+#  error SIG_ATOMIC_MIN not defined
 #endif
 
 #ifndef SIG_ATOMIC_MAX
-#error SIG_ATOMIC_MAX not defined
+#  error SIG_ATOMIC_MAX not defined
 #endif
 
 #ifndef SIZE_MAX
-#error SIZE_MAX not defined
+#  error SIZE_MAX not defined
 #endif
 
 #ifndef WCHAR_MIN
-#error WCHAR_MIN not defined
+#  error WCHAR_MIN not defined
 #endif
 
 #ifndef WCHAR_MAX
-#error WCHAR_MAX not defined
+#  error WCHAR_MAX not defined
 #endif
 
 #ifndef WINT_MIN
-#error WINT_MIN not defined
+#  error WINT_MIN not defined
 #endif
 
 #ifndef WINT_MAX
-#error WINT_MAX not defined
+#  error WINT_MAX not defined
 #endif
 
 #ifndef INT8_C
-#error INT8_C not defined
+#  error INT8_C not defined
 #endif
 
 #ifndef INT16_C
-#error INT16_C not defined
+#  error INT16_C not defined
 #endif
 
 #ifndef INT32_C
-#error INT32_C not defined
+#  error INT32_C not defined
 #endif
 
 #ifndef INT64_C
-#error INT64_C not defined
+#  error INT64_C not defined
 #endif
 
 #ifndef UINT8_C
-#error UINT8_C not defined
+#  error UINT8_C not defined
 #endif
 
 #ifndef UINT16_C
-#error UINT16_C not defined
+#  error UINT16_C not defined
 #endif
 
 #ifndef UINT32_C
-#error UINT32_C not defined
+#  error UINT32_C not defined
 #endif
 
 #ifndef UINT64_C
-#error UINT64_C not defined
+#  error UINT64_C not defined
 #endif
 
 #ifndef INTMAX_C
-#error INTMAX_C not defined
+#  error INTMAX_C not defined
 #endif
 
 #ifndef UINTMAX_C
-#error UINTMAX_C not defined
+#  error UINTMAX_C not defined
 #endif
diff --git a/libcxx/test/extensions/msvc/math_h.compile.pass.cpp b/libcxx/test/extensions/msvc/math_h.compile.pass.cpp
index 045745b5f..fcf1b40f8 100644
--- a/libcxx/test/extensions/msvc/math_h.compile.pass.cpp
+++ b/libcxx/test/extensions/msvc/math_h.compile.pass.cpp
@@ -16,11 +16,11 @@
 //
 
 #ifdef _MSC_VER
-#   include <math.h>
-#   define _USE_MATH_DEFINES
-#   include <math.h>
+#  include <math.h>
+#  define _USE_MATH_DEFINES
+#  include <math.h>
 
-#   ifndef M_PI
-#       error M_PI not defined
-#   endif
+#  ifndef M_PI
+#    error M_PI not defined
+#  endif
 #endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldionne ldionne ldionne approved these changes

Assignees
No one assigned
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philnik777 @llvmbot @ldionne