-
Notifications
You must be signed in to change notification settings - Fork 0
Added files for the single event page #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a complete single event page template for displaying workshop details with a clean, structured layout. The implementation separates content from presentation by using YAML metadata for easy customization by non-technical users.
- Creates a new Quarto document template with comprehensive metadata structure for event information
- Implements responsive CSS styling with hover effects and visual feedback for interactive elements
- Provides a reusable template system where event details can be modified through YAML frontmatter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
events/styles.css | Comprehensive CSS styling for event page layout with interactive elements and responsive design |
events/individual_event.qmd | Quarto template with YAML metadata structure and HTML rendering for event information display |
|
||
.location-text:hover { | ||
transform: scale(1.02); | ||
color: #06793f;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extra semicolon at the end of the color property. Remove one semicolon to fix the syntax error.
color: #06793f;; | |
color: #06793f; |
Copilot uses AI. Check for mistakes.
workshop_website: "https://lmu-osc.github.io/2025-03-24-LMU-Humanities/" | ||
|
||
# Event Description | ||
event_description: "In this Software Carpentry Workshop you will learn the **Unix Shell**, **Git** and **R**. This example-driven **two-day workshop** will teach core computing skills that will help you be more productive and effective. We'll alternate short tutorials with hands-on practical exercises. Participants are encouraged to help one another and to apply what they are learning to their own research problems during the workshop." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'tempalte' in the PR description should be 'template', but this appears to be in the PR metadata rather than the code itself.
Copilot uses AI. Check for mistakes.
<li><a href="{{< meta instructors.1.url >}}" target="_blank">{{< meta instructors.1.name >}}</a></li> | ||
<li><a href="{{< meta instructors.2.url >}}" target="_blank">{{< meta instructors.2.name >}}</a></li> | ||
<li><a href="{{< meta instructors.3.url >}}" target="_blank">{{< meta instructors.3.name >}}</a></li> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instructor list uses hardcoded array indices (1, 2, 3). This creates a maintenance issue when the number of instructors changes, as both the YAML metadata and HTML template must be manually synchronized. Consider using a loop or dynamic rendering approach.
<li><a href="{{< meta instructors.1.url >}}" target="_blank">{{< meta instructors.1.name >}}</a></li> | |
<li><a href="{{< meta instructors.2.url >}}" target="_blank">{{< meta instructors.2.name >}}</a></li> | |
<li><a href="{{< meta instructors.3.url >}}" target="_blank">{{< meta instructors.3.name >}}</a></li> | |
{{% for instructor in instructors %}} | |
<li><a href="{{ instructor.url }}" target="_blank">{{ instructor.name }}</a></li> | |
{{% endfor %}} |
Copilot uses AI. Check for mistakes.
Modified to make the content in the metadata so that an unexperienced user can easily modify the tempalte.