Add Execution Context to Errors #480
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsantilena
commented
Feb 10, 2023
| context: Backtrace::capture(), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Had to create custom error type and constructor to pass the backtrace information along.
stsantilena
commented
Feb 10, 2023
| ErrorKind::PathNotFound => ContextError::new(Error::PathNotFound), | ||
| ErrorKind::WatchNotFound => ContextError::new(Error::WatchNotFound), | ||
| ErrorKind::InvalidConfig(c) => ContextError::new(Error::InvalidConfig(c)), | ||
| ErrorKind::MaxFilesWatch => ContextError::new(Error::MaxFilesWatch), |
There was a problem hiding this comment.
Wrapping our original Error type with the ContextError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an error wrapper around our existing error type in the
notify-streamlibrary. It usesstd::backtraceto capture the backtrace at the time of the error and returns it with the error:Testing:
Technical Notes:
Originally tried using the
traceing_errorcrate but ran into issues. I couldn't get theSpanTrace::capture()function to work. Also, thein_current_span()method was not adding the SpanTrace to the Span as expected. That's why I pivoted to usingstd::backtraceinstead. The downside is that It's a bit code heavy and may have performance implications if used too often.JIRA Link: LOG-15034