Fixes #154: Enable zoom in Nightscout view #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestSuccess DetailsI confirmed the warning present when building |
marionbarker
approved these changes
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #154.
Description
This PR introduces two improvements to the
NightscoutViewController:Enables Pinch-to-Zoom: The Nightscout page disables user scaling via its viewport
<meta>tag. This change injects a small JavaScript snippet after the page loads to override this setting (user-scalable=0), allowing users to pinch-to-zoom on the graph as requested in the issue.Fixes Deprecation Warning: Updates the code to resolve a warning for
javaScriptEnabled, which was deprecated in iOS 14. It now uses the modernWKWebpagePreferencesAPI to enable JavaScript, improving code health and future compatibility.How to Test
javaScriptEnabled.