Skip to content

Enlarge BG text and add optional display name #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025

Conversation

bjorkert
Copy link
Contributor

This PR introduces several enhancements to the Snoozer view to improve at-a-glance readability and provide better user context, addressing Issue #440 .

Key Changes:

  • Larger BG Text: The font size and frame for the BG value have been increased, making it the primary focal point of the view.
  • Optional Display Name: The app's display name can now be shown in the rightColumn, which works well in both portrait and landscape modes. This is controlled by the showDisplayName setting.
  • Adaptive Landscape Layout: In landscape mode, the trend arrow and delta value are now displayed side-by-side for a more compact and readable layout.

@bjorkert bjorkert requested a review from marionbarker July 19, 2025 14:56
@bjorkert bjorkert linked an issue Jul 19, 2025 that may be closed by this pull request
@bjorkert
Copy link
Contributor Author

bjorkert commented Jul 19, 2025

65F64591-15BB-4A8E-8A5F-6F6F5F13153D_4_5005_c
7A79AD4C-F3C5-4458-9458-ED3D5446A2F4_4_5005_c
Simulator 2025-07-19 18 45 06
Simulator 2025-07-19 18 44 32

@marionbarker
Copy link
Collaborator

marionbarker commented Jul 19, 2025

Summary

Overall - works as coded.
Questions

  • seems like the name on snoozer should be in bigger font too (I'd make the name bigger than the emoji) and in portrait maybe above the glucose
  • we decided not to do this one: I think the default for a new instance (not a rebuild) of LoopFollow should configure the name to be enabled

Test

Looks good. These results were with LoopFollow, General Settings, Show Display Name enabled. After I captured the screenshots, I enabled Snoozer emoji too - I like that. (I know you added it a while ago.) Snoozer screen still good with emoji and name both enabled.

Portrait with dev (left) and with PR (right):

lf-441-portrait

Landscape with dev (upper) and with PR (lower):

lf-441-landscape

Copy link
Collaborator

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code and tested. I remarked on some possible modifications. But I approve as is if you decide not to include these suggestions.

@bjorkert
Copy link
Contributor Author

Updated the display name presentation in SnoozerView:

  • Increased font size from ~22pt to 50pt bold for better visibility
  • In portrait mode: Display name now appears above the glucose value (handled by leftColumn)
  • In landscape mode: Display name remains in the right column with the larger font

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bigger bg text in snoozer view and show display name in snoozer view
2 participants