Fix: Connection terminated unexpectedly error not caught in on error listener #781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our application was crashing when the database connection unexpectedly failed. This happened because:
removeAllListeners('error')
, which unintentionally removed the pg library's error handlers.We've fixed this by:
removeAllListeners('error')
call within the connector. This ensures that the pg library's built-in error handling for connection issues remains active.(!pg.listenerCount('error'))
. This prevents us from creating too many listeners (addressing past MaxEventListeners warnings) while ensuring all critical connection errors are still properly managed.Fixes #778
See also #746
Checklist
npm test
passes on your machine