Fix OT_DISABLE_HARDENING -Werror,-Wundef error #28405
Open
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How neat! I didn't even know that one could use @nasahlpa: Would you mind taking a look at this? The other way we might do it is to switch the flag to just depend on whether it was defined and use |
korran
force-pushed
the
hardening-warning
branch
from
9fc5611 to
c7c094a
Compare
In file included from lib/crypto/crypto_ipc.c:10: In file included from external/lowrisc_opentitan+/sw/device/lib/crypto/include/ecc_p256.h:8: In file included from external/lowrisc_opentitan+/sw/device/lib/crypto/include/datatypes.h:12: external/lowrisc_opentitan+/sw/device/lib/base/hardened.h:244:37: error: 'OT_DISABLE_HARDENING' is not defined, evaluates to 0 [-Werror,-Wundef] Signed-off-by: Kor Nielsen <[email protected]>
korran
force-pushed
the
hardening-warning
branch
from
c7c094a to
e08828d
Compare
nasahlpa
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In file included from lib/crypto/crypto_ipc.c:10:
In file included from external/lowrisc_opentitan+/sw/device/lib/crypto/include/ecc_p256.h:8: In file included from external/lowrisc_opentitan+/sw/device/lib/crypto/include/datatypes.h:12: external/lowrisc_opentitan+/sw/device/lib/base/hardened.h:244:37: error: 'OT_DISABLE_HARDENING' is not defined, evaluates to 0 [-Werror,-Wundef]