Skip to content

DM-50223: Refresh LSSTCam tests with newer data, use real angle for LSSTCam tests. #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025
Merged

DM-50223: Refresh LSSTCam tests with newer data, use real angle for LSSTCam tests. #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48f2997
Revert "Don't send fake angle for LSSTCam tests."
erinleighh Jun 30, 2025
9bdea89
Update Playbook Testers section for LSSTCam.
erinleighh Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/playbook.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ Sample command line:
.. code-block:: sh

python upload.py LATISS 3
python upload.py LSSTCam 2
python upload.py LSSTCam 5
python upload.py LSSTCam-imSim 2

This script draws images stored in the ``rubin-pp-dev-users`` bucket.
Expand All @@ -541,7 +541,7 @@ This script draws images stored in the ``rubin-pp-dev-users`` bucket.
One of the files, the unobserved group `2024-09-04T05:59:29.342`, has no templates and is known to fail `calibrateImage` in determining PSF.
This visit can test pipeline fallback features.
* For LSSTComCamSim, 2 groups, in total 18 raw fits files and their corresponding json metadata files, are curated.
* For LSSTCam, 2 groups, in total 2 raw fits files and their corresponding json metadata files, are curated.
* For LSSTCam, 5 groups, in total 10 raw fits files and their corresponding json metadata files, are curated.
* For LSSTCam-imSim, 2 groups, in total 3 raw fits files and custom-made json metadata files, are curated.

``python/tester/upload_from_repo.py``: Command line arguments are a configuration file, and the number of groups of images to send.
Expand Down
8 changes: 1 addition & 7 deletions python/tester/upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,6 @@ def get_samples_lsst(bucket, instrument):
raise RuntimeError(f"Unable to retrieve JSON sidecar: {sidecar}")
with sidecar.open("r") as f:
md = json.load(f)
angle_sys = FannedOutVisit.RotSys.SKY

sal_index = INSTRUMENTS[instrument].sal_index
# Use special sal_index to indicate a subset of detectors
Expand All @@ -314,11 +313,6 @@ def get_samples_lsst(bucket, instrument):
physical_filter = md["FILTER"]
if instrument == "LATISS":
physical_filter = f"{physical_filter}~empty"
# LSSTCam currently only has lab data, no real sky angle
# TODO: remove when switching to on-sky data
if instrument == "LSSTCam":
angle_sys = FannedOutVisit.RotSys.NONE
md["ROTPA"] = 0.0
visit = FannedOutVisit(
instrument=instrument,
detector=_DETECTOR_FROM_RS[instrument][m["raft_sensor"]],
Expand All @@ -328,7 +322,7 @@ def get_samples_lsst(bucket, instrument):
coordinateSystem=FannedOutVisit.CoordSys.ICRS,
position=[md["RA"], md["DEC"]],
startTime=astropy.time.Time(md["DATE-BEG"], format="isot", scale="tai").unix_tai,
rotationSystem=angle_sys,
rotationSystem=FannedOutVisit.RotSys.SKY,
cameraAngle=md["ROTPA"],
survey="SURVEY",
salIndex=sal_index,
Expand Down