DM-50087: Preload IERS data in Prompt Processing #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-50087
branch
from
e239685 to
c0b3b11
Compare
We don't need any special support to handle setting up and tearing down mock patchers; TestCase.enterContext does exactly what's needed.
This lets Prompt Processing access a cache that's been prepared at USDF, instead of a potentially slow download from official repos.
The updater can run in either service or initializer pods. It needs an extra variable (CENTRAL_IERS_CACHE) to know what to download; default is to skip download.
The function checks if the cache has already been imported and skips download if that's the case.
kfindeisen
force-pushed
the
tickets/DM-50087
branch
from
c0b3b11 to
1d2477d
Compare
ktlim
approved these changes
Jul 3, 2025
ktlim
reviewed
Jul 3, 2025
| astropy.utils.data.download_file(url, cache="update") | ||
| with tempfile.NamedTemporaryFile(suffix=".zip") as local_cache: | ||
| astropy.utils.data.export_download_cache(local_cache, IERS_URLS, overwrite=True) | ||
| dest = lsst.resources.ResourcePath(args.destination) |
There was a problem hiding this comment.
While we can run this multiple times for different destinations, it seems that it wouldn't be a lot harder to take a list of destinations here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a two-part system for caching IERS data at USDF and importing it into Prompt Processing at pod start. This is expected to be faster than a direct download from IERS/ObsPM, and ensures that we do not download in the middle of processing (though by happening at pod start it will still reduce our response time at the start of a sequence).