Skip to content

DM-42200: add defects focal plan plots #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DM-42200: add defects focal plan plots #407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
763f87e
Add Defects focal plot.
aferte Dec 20, 2024
021cc34
From number of pix to percent.
aferte Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions pipelines/cpCore.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,25 +232,50 @@ tasks:
class: lsst.analysis.tools.tasks.VerifyCalibAnalysisTask
config:
connections.outputName: cpDefectCore
connections.data: verifyDefectResults
connections.data: verifyDefectsResults

atools.defectsPixels: CalibStatisticFocalPlanePlot
atools.defectsPixels.produce.plot.addHistogram: false
# here set name of column from the verify table
atools.defectsPixels.quantityKey: DEFECTS_DEFECT_PIXELS
atools.defectsPixels.unit: "pix"

atools.defectsPixelsFrac: CalibStatisticFocalPlanePlot
atools.defectsPixelsFrac.produce.plot.addHistogram: false
atools.defectsPixelsFrac.quantityKey: DEFECTS_FRAC
atools.defectsPixelsFrac.unit: "pix"

atools.defectsPixelsFracNoEdge: CalibStatisticFocalPlanePlot
atools.defectsPixelsFracNoEdge.produce.plot.addHistogram: false
atools.defectsPixelsFracNoEdge.quantityKey: DEFECTS_FRAC_NOEDGE
atools.defectsPixelsFracNoEdge.unit: "pix"

atools.defectsPixelsRequirement: CalibStatisticFocalPlanePlot
atools.defectsPixelsRequirement.produce.plot.addHistogram: false
atools.defectsPixelsRequirement.produce.plot.plotMin: 0
atools.defectsPixelsRequirement.produce.plot.plotMax: 1
atools.defectsPixelsRequirement.quantityKey: DEFECTS_REQUIREMENT
atools.defectsPixelsRequirement.unit: "---"

# TODO: DM-43880 Sort out defects
atools.defectsHotPixels: CalibStatisticFocalPlanePlot
atools.defectsHotPixels.produce.plot.addHistogram: true
atools.defectsHotPixels.produce.plot.zAxisLabel: "Number of Hot Pixels"
atools.defectsHotPixels.quantityKey: DEFECTS_DEFECTS_DIST_N_HOT
atools.defectsHotPixels.unit: "---"
# atools.defectsHotPixels: CalibStatisticFocalPlanePlot
# atools.defectsHotPixels.produce.plot.addHistogram: true
# atools.defectsHotPixels.produce.plot.zAxisLabel: "Number of Hot Pixels"
# atools.defectsHotPixels.quantityKey: DEFECTS_DEFECTS_DIST_N_HOT
# atools.defectsHotPixels.unit: "---"

# atools.defectsColdPixels: CalibStatisticFocalPlanePlot
# atools.defectsColdPixels.produce.plot.addHistogram: true
# atools.defectsColdPixels.produce.plot.zAxisLabel: "Number of Cold Pixels"
# atools.defectsColdPixels.quantityKey: DEFECTS_DEFECTS_DIST_N_COLD
# atools.defectsColdPixels.unit: "---"

# atools.defectsBadColumns: CalibStatisticFocalPlanePlot
# atools.defectsBadColumns.produce.plot.addHistogram: true
# atools.defectsBadColumns.produce.plot.zAxisLabel: "Number of Hot Pixels"
# atools.defectsBadColumns.quantityKey: DEFECTS_DEFECTS_DIST_N_BAD_COLUMNS
# atools.defectsBadColumns.unit: "---"

python: |
from lsst.analysis.tools.atools import *

Expand Down
Loading