Skip to content

Test enhancment for PHPUnit fixtures and version #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peter279k
Copy link

Changed log

  • It seems that the package requires php-7.1 version at least. Setting the correct version semver for PHP.
  • Removing some invalid attributes on phpunit.xml.dist file.

These invalid attribute messages are as follows:

Line 10:
  - Element 'phpunit', attribute 'mapTestClassNameToCoveredClassName': The attribute 'mapTestClassNameToCoveredClassName' is not allowed.
  - Element 'phpunit', attribute 'strict': The attribute 'strict' is not allowed.

  Line 21:
  - Element 'log', attribute 'title': The attribute 'title' is not allowed.
  - Element 'log', attribute 'charset': The attribute 'charset' is not allowed.
  - Element 'log', attribute 'yui': The attribute 'yui' is not allowed.
  - Element 'log', attribute 'highlight': The attribute 'highlight' is not allowed.

  Line 23:
  - Element 'log', attribute 'logIncompleteSkipped': The attribute 'logIncompleteSkipped' is not allowed.

  Line 27:
  - Element 'blacklist': This element is not expected. Expected is ( whitelist ).
  • According to the official PHPUnit doc, it should be protected function setUp(): void and protected function tearDown(): void.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant