Skip to content

Resolve failing unit tests in Moodle 4.3 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ScottVerbeek
Copy link

This merge request includes the fixes for issues:

Here is the run for the testsuite block_quickmail_testsuite on Moodle 4.3.

root@b254dc51a88f:/var/www/vanilla-403# vendor/bin/phpunit --testsuite=block_quickmail_testsuite 
Moodle 4.3+ (Build: 20231201), a418e9e53aef54f624cec25c48a4b2bfe7bd4524
Php: 8.1.24, pgsql: 14.0 (Debian 14.0-1.pgdg110+1), OS: Linux 6.4.12-060412-generic x86_64
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

...............................................................  63 / 253 ( 24%)
............................................................... 126 / 253 ( 49%)
............................................................... 189 / 253 ( 74%)
............................................................... 252 / 253 ( 99%)
.                                                               253 / 253 (100%)

Time: 00:48.855, Memory: 90.50 MB

OK (253 tests, 1013 assertions)

Matthias Opitz and others added 4 commits November 8, 2023 14:39
Fixing helper function to update system config values, ensuring it uses set_config() to update the database table and clears the cache appropriately. This resolves issues with later functions relying on get_config() instead of get_record() to fetch the updated values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants