Paper review #2
Open
Paper review #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer american english, "Wi-Fi", "vs.", etc. and fix a few typos.
In contrary to switchdev which is a stateless API that switch-ish drivers can implement, DSA tracks the state of a switch fabric (a.k.a. a tree), its switch chips and their switch ports. Thus mention that DSA is stateful, not stateless.
|
LGMT, just one thing: why the s/MV88/88/? |
|
s/MV88/88/ because there is no MV prefix to the Marvell switch family naming. |
|
Correct, the datasheets refer to 88e6352, for example. But within the driver, we use the MV prefix. So we need to look at the context, and decide if the text is are referring to the device, or something within the driver. |
|
What is the Broadcom convention? Is the device bcm7445d0, or just 7445d0? |
|
We must use 88E6352 when talking about Marvell chips because that is the name given by the manufacturer. The MV prefix is just there because of a limitation of the C language ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixups go in the first commit, while the second one may raise concerns.
Cc: @ffainelli