Require Java 1.8 to build, bump maven-plugin-plugin version #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we required Java 1.6 to compile (a corresponding entry had to be made in ~/.m2/toolchains.xml), however the code already required try-with-resources (HelpMojo). Bump source code compatibility to Java 1.8, and remove the JDK 1.6 requirement from Maven POM files. Also update the maven-plugin-plugin version, which seems to fix a related problem when running with newer Maven environments.
|
That would break backward compatibility with old Maven versions: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we required Java 1.6 to compile (a corresponding entry had to be made in ~/.m2/toolchains.xml), however the code already required try-with-resources (HelpMojo).
Bump source code compatibility to Java 1.8, and remove the JDK 1.6 requirement from Maven POM files.
Also update the maven-plugin-plugin version, which seems to fix a related problem when running with newer Maven environments.