Skip to content

chore: fix some minor issues in the comments #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: fix some minor issues in the comments #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@magic-sdk/provider/src/util/promise-tools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { UserEventsEmit, UserEventsOnReceived } from '@magic-sdk/types';
import { TypedEmitter, EventsDefinition, createTypedEmitter } from './events';

/**
* Extends `Promise` with a polymorphic `this` type to accomodate arbitrary
* Extends `Promise` with a polymorphic `this` type to accommodate arbitrary
* `Promise` API extensions.
*/
interface ExtendedPromise<T> extends Promise<T> {
Expand Down
2 changes: 1 addition & 1 deletion packages/@magic-sdk/provider/src/util/web-crypto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export function clearKeys() {
}

export async function createJwt() {
// will return undefiend is webcrypto is not supported
// will return undefined is webcrypto is not supported
const publicJwk = await getPublicKey();

if (!publicJwk) {
Expand Down
2 changes: 1 addition & 1 deletion packages/@magic-sdk/react-native-bare/src/react-native-webview-controller.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export class ReactNativeWebViewController extends ViewController {
// Validating this logic requires lots of React-specific boilerplate. We will
// revisit this method for unit testing in the future. For now, manual testing
// is sufficient (this logic is stable right now and not expected to change in
// the forseeable future).
// the foreseeable future).
/* istanbul ignore next */
public Relayer: React.FC<{ backgroundColor?: string }> = backgroundColor => {
const [show, setShow] = useState(false);
Expand Down
4 changes: 2 additions & 2 deletions packages/@magic-sdk/react-native-expo/src/react-native-webview-controller.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export class ReactNativeWebViewController extends ViewController {
// Validating this logic requires lots of React-specific boilerplate. We will
// revisit this method for unit testing in the future. For now, manual testing
// is sufficient (this logic is stable right now and not expected to change in
// the forseeable future).
// the foreseeable future).
/* istanbul ignore next */
public Relayer: React.FC<{ backgroundColor?: string }> = backgroundColor => {
const [show, setShow] = useState(false);
Expand Down Expand Up @@ -204,7 +204,7 @@ export class ReactNativeWebViewController extends ViewController {
if (
event.nativeEvent &&
typeof event.nativeEvent.data === 'string' &&
/* Backward comaptible */
/* Backward compatible */
(event.nativeEvent.url === `${this.endpoint}/send/?params=${encodeURIComponent(this.parameters)}` ||
event.nativeEvent.url === `${this.endpoint}/send/?params=${this.parameters}`)
) {
Expand Down