Fix notion-create-pages date property serialization bug #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue where expanded date properties like "date:PropertyName:start"
were silently dropped during OpenAPI-to-MCP conversion, causing empty date
columns in Notion UI.
Changes:
- Modified OpenAPIToMCPConverter to allow additionalProperties for "properties"
field in post-page and patch-page operations
- Added validation and debug logging in HttpClient for date property tracking
- Added comprehensive unit tests to prevent regression
Before: { "date:Date:is_datetime": 0 } - start field dropped
After: { "date:Date:start": "2025-10-10", "date:Date:is_datetime": 0 } - preserved
Fixes makenotion#121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue where expanded date properties like "date:PropertyName:start"
were silently dropped during OpenAPI-to-MCP conversion, causing empty date
columns in Notion UI.
Changes:
Before: { "date:Date:is_datetime": 0 } - start field dropped
After: { "date:Date:start": "2025-10-10", "date:Date:is_datetime": 0 } - preserved
Fixes #121